How to compare string to string array?

Question

Im trying to write a program that takes a password created by a user and compares it to an array of strings. The password has to be a word not in the array. For example: The user enters the password "about" and that word is in the array so it will return "Wrong". What i've tried dosent work, Can someone help?

Here's everything i have so far:

int main()

{
    int i;
    char dict[998][15];
    char password[30];
    size_t ind; 

    FILE *fp = fopen("dictionary.txt", "r");

    if (fp != NULL) 
    {
      
        for (ind = 0; fgets(dict[ind], sizeof dict[0], fp) && ind < sizeof dict / sizeof dict[0]; ind++)
        {
            dict[ind][strcspn(dict[ind], "\n")] = '\0'; 
        }

  
    }
    else
    {
        printf("Error opening file");
    }
    fclose(fp);
     printf("Please enter Password: ");
     scanf("%s",password);
    //Checking if password is in array.
       for (size_t i = 0; i < ind; i++) 
       {
             if (!strcmp(password, dict[i])) 
             {
                 printf("Wrong");
             }
             else
             {
                 printf("Correct");
             }
       }
   
}

Define "dosent work".

jorge is not ai
– jorge is not ai

2021-03-28 23:10:42 +00:00
Commented Mar 28, 2021 at 23:10 — jorge is not ai
– jorge is not ai, Commented Mar 28, 2021 at 23:10
@user14063792468 It returns Correct 998 times

Kazumi411
– Kazumi411

2021-03-28 23:12:36 +00:00
Commented Mar 28, 2021 at 23:12 — Kazumi411
– Kazumi411, Commented Mar 28, 2021 at 23:12

Ion Larrañaga · Accepted Answer · 2021-03-28 23:17:03Z

1

You are writing "Correct" or "Wrong" for every checked word in the dictionary. You have to stop checking if the word appears in the dictionary, and if all words are checked and the password does not appear, then print "Correct".

A possible implementation that just prints the result and exits would be something like:

printf("Please enter Password: ");
scanf("%s", password);
//Checking if password is in array.
for (size_t i = 0; i < ind; i++)
{
    if (!strcmp(password, dict[i]))
    {
        printf("Wrong");
        return -1;
    }
}
printf("Correct");
return 0;

answered Mar 28, 2021 at 23:17

Ion Larrañaga

5042 silver badges5 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kazumi411 Over a year ago

This stops the printing issue, but showed me a new one. The loop isn't checking all of the strings. For example the first string in the array is "about" and the last is "zoo". When i enter the password as "about" it gives me "Correct". But when i enter the password as "zoo" it says "Wrong" when both should say wrong.

Ion Larrañaga Over a year ago

I think that maybe your dictionary is wrong (some white space after about?). I would try to reduce the dictionary just to those two entries (about and zoo) and check if the error is reproduced. In that case, I would debug the program and check what happens in the comparison. If you are not used to debuggers (you should start playing with them), just add some printf just before the strcmp to see if what you are comparing is the same. For instance: printf ("Comparing '%s' and '%s'\n", password, dict[i]); Don't forget the quotes because it makes detecting white spaces easier.

Collectives™ on Stack Overflow

How to compare string to string array?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related