How to reuse code and avoid duplicate code Nodejs

Question

I have the following problem, I have a function that detects when a message has arrived, and when the message contains the prefix "#" for example "Hello I mean #LOL" it only gets the "LOL". And it works very well indeed, but now I want it to be able to detect not only the "#" prefix but also the "$" prefix for example $ MONEY. The first thing that occurred to me was to literally copy the entire function and declare for example prefixD = "$". The problem is that I have a lot of repeated / duplicated code, and I think it is not good to do it like that, what would be the correct way to do it? I leave my code here (Which works, but it has a lot of duplicate code)

client.on("message", function consigue(msg) {

  const prefix = "#";
  if (!msg.content.includes(prefix)) return;

  const pattern = new RegExp(prefix + "([a-z]+)", "i");
  const getMatch = (str) => str.match(pattern)?.[1];
  
  TRADE_OUT = getMatch(msg.content);

  if (TRADE_OUT != "") {
   // some here
  }

  });

  client.on("message", function consigueD(msg) {
  const prefixD = "$";

  if (!msg.content.includes(prefixD)) return;

  function escapeRegex(string) {
    return string.replace(/[-\/\\^$*+?.()|[\]{}]/g, '\\$&');
  }
  const pattern = new RegExp(escapeRegex(prefixD) + '([a-z]+)', 'i');
  const getMatch = (str) => str.match(pattern)?.[1];

  TRADE_OUT = getMatch(msg.content);

  if (TRADE_OUT != "") {
  // The same some here
  }
 });

For example I would like to replace that

if (TRADE_OUT != "") {
      
      }

which is repeated in the two functions and is exactly the same code , and everything it has inside as it is done with the functions in the modules, which are declared only as name (); and they already execute all the code they have inside, and you can use it as many times as you want.

What would be the best way to do everything in the same function? I have tried with || , and in many other ways but the truth is I'm not very good with this topic

So you want the same behavior for # and $? In this case you could store them in an array and check if the message content contains one of these elements. — e.Fro
– e.Fro, Commented Mar 23, 2021 at 22:50
It's not clear what you're asking for in a design. Do you want one function that handles multiple prefixes? Do you want a common function that you can pass a prefix to and it will process that specific prefix? Or something else? — jfriend00
– jfriend00, Commented Mar 23, 2021 at 23:18
Yes, a function that handles both prefixes would be great But in reality any solution would serve me with the one that does not have as much repeated code as I have now — Jabibi
– Jabibi, Commented Mar 24, 2021 at 13:19

Vodis · Accepted Answer · 2021-03-23 23:09:59Z

1

You could make a factory.

let handlerFactory = flag => {
    return msg => {
        const prefix = flag
        ...
    }
}

Then you would do

client.on("message", handlerFactory("X"))

where X is either "$" or "#".

EDIT: If you meant "just the part within the TRADE_OUT-bit is a duplicate" then just take that, put it in a function declared before the handlers and call that from within the TRADE_OUT-bit.

edited Mar 23, 2021 at 23:09

answered Mar 23, 2021 at 23:04

Vodis

1221 silver badge8 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to reuse code and avoid duplicate code Nodejs

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related