Problem finding the largest element in an array

Question

I'm trying to write a function that receives a string of integers -I know this is not the ideal but it is how I was asked to do in an exercise-, puts them into an array an then gets the max value, minimal value, reads the entire array and counts how many times the max value was surpassed, and for last gives the position of the minimal value.

This is my code:

function performance(string) {

    let arrayScore = string.split(' ') //this part works as I tested before, the numbers of the string are correctly passed to the array

    let max = arrayScore[0]
    let min = arrayScore[0]

    let worstgame = 1
    let surpasses = 0

    for (let i = 0; i < arrayScore.length; i++) {

        if (max < arrayScore[i]) {

            max = arrayScore[i]
            surpasses++
        }

        if (min > arrayScore[i]) {

            min = arrayScore[i]
            worstgame = i + 1
        }
    }

    //max = arrayScore.reduce((a, b) => Math.max(a, b))
    //min = arrayScore.reduce((a, b) => Math.min(a, b))

    return [surpasses, worstgame, max, min]
}

let score = "10 20 20 8 25 3 0 30 1"

console.log(performance(score)) /*here is the problem: the value 8 is attributed to 'max' -should be 30- and the number of surpasses returns 2 -should be 3-*/

I noticed that I can get the max value by using Math.max as an argument in reduce, but I still don't understand why counting the surpasses and the "if" condition for "max" in the "for" loop are not working.

Does this answer your question? How might I find the largest number contained in a JavaScript array? — Tom Roman
– Tom Roman, Commented Mar 10, 2021 at 14:51
Does this answer your question? Find the min/max element of an array in JavaScript — Wyck
– Wyck, Commented Mar 10, 2021 at 15:40
This was already asked,refer to the below link. stackoverflow.com/a/52613528/11781464 — RAJENDRA H
– RAJENDRA H, Commented Mar 10, 2021 at 15:42

user8082655 · Accepted Answer · 2021-03-10 14:51:49Z

1

You compare numbers as strings, so '30' < '8' returns true :). Just use Number.parseInt() in order to get a number from a string (e.g. Number.parseInt(max) < Number.parseInt(arrayScore[i]))

answered Mar 10, 2021 at 14:51

user8082655

Sign up to request clarification or add additional context in comments.

2 Comments

pilchard Over a year ago

Always supply a radix when using parseInt - from the docs: Be careful—this does not default to 10!

MinusFour Over a year ago

It's just easier to use the + operand here. string.split(' ').map(Number) is also more convenient.

Taimoor Qureshi · Accepted Answer · 2021-03-10 15:11:12Z

0

how you can do that

function performance(str) {
let scoreArr = str.split(' ').map(data => Number(data))
  return scoreArr.reduce((max, num) => {
           return max > num ? max : num; 
},0)
}

let score = "10 20 20 8 25 3 0 30 1"

console.log(performance(score))
// 30

edited Mar 10, 2021 at 15:11

answered Mar 10, 2021 at 15:02

Taimoor Qureshi

6304 silver badges14 bronze badges

1 Comment

Wyck Over a year ago

If it's just a few numbers (~ fewer than thousands) you can use Math.max(...str.split(' ').map(Number)

Collectives™ on Stack Overflow

Problem finding the largest element in an array

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related