Debugging Javascript Click handler in Chrome 12

Question

oLink = document.getElementById("ItemDescend");
alert(oLink); // fire up alert with link target
addEventHandler(oLink, "click", function(e) { alert(1); sortTable('theList', 0, true); preventDefault(e); },false); // does not fire up inner alert!

This above code functions in all other browsers as tested, but in Chrome 12 does not. I would be grateful if someone shows me a solution. Thanks.

What is addEventHandler? You have to post the implementation, otherwise we cannot help. — Felix Kling
– Felix Kling, Commented Jul 6, 2011 at 2:52
function(oNode, sEvt, fnHandler, bCapture) { if (typeof (window.event) != "undefined") oNode.attachEvent("on" + sEvt, fnHandler); else oNode.addEventListener(sEvt, fnHandler, bCapture); }, — Dexy_Wolf
– Dexy_Wolf, Commented Jul 6, 2011 at 2:55
That is because Chrome does have window.event, but it does not have attachEvent. It would be better to check if oNode has attachEvent defined. Even better, use a framework that abstracts these details away. — Matt Greer
– Matt Greer, Commented Jul 6, 2011 at 2:59
But on window load event this function is working.. How is that possible? — Dexy_Wolf
– Dexy_Wolf, Commented Jul 6, 2011 at 3:03

SLaks · Accepted Answer · 2011-07-06 02:57:11Z

1

Your addEventHandler method is checking for an unrelated property, which is wrong.

Instead, you should check for the addEventListener method, and only call attachEvent if that doesn't exist.
Change the condition to

if (typeof (oNode.addEventListener) !== "function")

answered Jul 6, 2011 at 2:57

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Matt Greer Over a year ago

It is working for me: jsfiddle.net/nqmJf you may have a typo or some other issue.

RobG Over a year ago

addEventListener is a host method and may not return function when tested with typeof (e.g. in IE, methods implemented using ActiveX return "unknown"), so probably better to use if (oNode.addEventListener).

Dexy_Wolf Over a year ago

I am getting [Object HTMLDivElement] in jsfiddle.net/nqmJf, not 1. And would suggest you to make that div a link, just in case... I didnt try it...

SLaks Over a year ago

@Rob: I was wondering about that. I had hoped that that was fixed by IE9, which is the only version with addEventListener.

RobG Over a year ago

@SLaks - IE may also return "object" and "other" for methods of host objects. I think the general rule is: don't depend on host objects implementing features of ECMAScript, code to the lowest common denominator (well, IE 6 and higher at least) :-)

|

SLaks · Accepted Answer · 2011-07-06 03:12:06Z

1

addEventHandler(obj,type,fn)
{
    if(obj.addEventListener)
    {
        obj.addEventListener(type,fn,false);
    }
    else if (obj.attachEvent)
    {
        obj.attachEvent("on"+type,fn);
    }

}

edited Jul 6, 2011 at 3:12

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

answered Jul 6, 2011 at 3:07

coaido

111 bronze badge

1 Comment

RobG Over a year ago

Probably worth noting that when called, the listener's this will be set differently depending on which method was used to add it.

Collectives™ on Stack Overflow

Debugging Javascript Click handler in Chrome 12

2 Answers 2

7 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related