PHP - Add form input into database

Question

I'm trying to add revived form input into database.

<form action="index.php" method="post">
<input type="text" name="firstname" id="firstname">
<br>
<input type="text" name="lastname" id="lastname">
<br>
<input type="submit" name="submit" value="Submit">

if(isset($_POST['submit'])) {
$firstname = $_POST['firstname'];
$lastname = $_POST['lastname'];

$query = "INSERT INTO users (firstname, lastname) VALUES ($firstname, $lastname)";
if($conn->query($query) === true) {
    echo "added";
}else {
    echo $con->error;
}

Example : Firstname = Jason / Lastname = Haw

After clicking on submit button, i see error message : Unknown column 'Jason' in 'field list'

Where is the wrong thing to do?

Please note: You are wide open to SQL Injections and should use parameterized prepared statements instead of manually building your queries. They are provided by PDO or by MySQLi. Never trust any kind of input. — Anatol Bivol
– Anatol Bivol, Commented Nov 22, 2020 at 16:59

YGYG · Accepted Answer · 2020-11-22 16:53:27Z

1

$query = "INSERT INTO users (firstname, lastname) VALUES ('$firstname', '$lastname')";

put single quote for $firstname.

but this is not a proper approach, you should use prepared statement. your query is risk of sql injection, because no escaping the input.

answered Nov 22, 2020 at 16:53

YGYG

1361 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jason Over a year ago

Thank you so much. Why i need to add single quote? im new in mysql, i pass example step by step.

YGYG Over a year ago

because $query is string. if you dont put single quote/double quote, the query will become INSERT INTO users (firstname, lastname) VALUES (abc, abc), the abc will treat as column name instead of value

Collectives™ on Stack Overflow

PHP - Add form input into database

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related