no modifications in XML file after running python code

Question

I wrote a code that must modify some values in a xml file. it looks to be working, but when i open this xml file threw PyCharm where i have added the modified file, it just doesn't change a thing. If anyone gave a respond to such a question, please point me where is it. Here is the code as well as the xml.

import xml.etree.ElementTree as ET
tree = ET.parse("farms.xml")
root = tree.getroot()
for elem in root.findall('farm'):
    elem.set('money', '2000')
    money = elem.get('money')
    print(money)

xml

<farms>
  <farm farmId="1" name="Моя ферма" color="1" loan="0.000000" money="213" loanAnnualInterestRate="304.166656">
  <players>
  </players>       
 </farm>
</farms>

You don’t appear to have included any code that’s writing changes back to the file in the file system - can you elaborate on how you came to the conclusion that the code provided here should function otherwise? — esqew
– esqew, Commented Nov 19, 2020 at 13:20
i thought that the set function would change in the elem the string with money to 2000. IDK why the ` isnt working — Just Started
– Just Started, Commented Nov 19, 2020 at 13:23
it is my first experience working with xml, could you tell me how should i do it otherwise? — Just Started
– Just Started, Commented Nov 19, 2020 at 13:25

balderman · Accepted Answer · 2020-11-19 13:37:20Z

1

What you are missing is writing the tree back to disk.

import xml.etree.ElementTree as ET

tree = ET.parse("farms.xml")
root = tree.getroot()
for elem in root.findall('farm'):
    elem.set('money', '2000')
with open('new_farms.xml', 'wb') as f:
    tree.write(f)

answered Nov 19, 2020 at 13:37

balderman

24k8 gold badges39 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Just Started Over a year ago

it does work, but the problem is i do not need to create a new file, can you help me replace the information in this one?

balderman Over a year ago

sure. just change open('new_farms.xml', 'wb') to open('farms.xml', 'wb')

balderman Over a year ago

@JustStarted Glad I managed to help. Feel free to up vote.

ghchoi · Accepted Answer · 2020-11-19 13:28:50Z

0

It works for me. Additionally,

print(xml.etree.ElementTree.tostring(root))

will show what you expect.

answered Nov 19, 2020 at 13:28

ghchoi

5,2064 gold badges38 silver badges59 bronze badges

3 Comments

Just Started Over a year ago

where shoul i add it. here is the V2 of the code.

import xml.etree.ElementTree as ET  def main(char):     tree = ET.parse("farms.xml")     root = tree.getroot()     for elem in root.findall('farm'):         elem.set('money', '2000')         money = elem.get(str(char))     print(xml.etree.ElementTree.tostring(root))   if __name__ == "__main__":     char = eval(input("ammount to be set "))     main(char)

Just Started Over a year ago

oh, i am sorry for that, hopefully you will get the idea

Just Started Over a year ago

it still doesn t work for me, what does it change for you and what is the setup you are working in

Collectives™ on Stack Overflow

no modifications in XML file after running python code

2 Answers 2

3 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related