Javascript JSON creation creating an additional object

Question

I'm trying to create an JSON from another JSON using Javascript.

Here is my code.

var data = [{
    "Id": "123",
    "Name": "Abc",
    "Amount": 110000
  },
  {
    "Id": "567",
    "Name": "DEF",
    "Amount": 98000
  },
  {
    "Id": "345",
    "Name": "XYZ",
    "Amount": 145000
  }
];

finalArray(data);

function finalArray(data) {
  var nArray = [];
  var subArray = new Object();
  subArray.total = 0;
  subArray.records = {};
  subArray.size = 0;
  data.forEach(item => {

    subArray.total += item.Amount;
    subArray.records += item;
    subArray.size += 1;
  });
  nArray.push(subArray);
  console.log(nArray);
};

Here In the final object, In records I'm getting the below output.

records: "[object Object][object Object][object Object][object Object]"

expected output is

records: "[object Object][object Object][object Object]"

where as in my actual data, I've 3 records in the input.

Please let me know where I'm going wrong.

Thanks

In my input I've 3 records, where as In my output, it is showing 4 records. @0stone0 — user3872094
– user3872094, Commented Oct 7, 2020 at 11:54
One of the [object Object]s is because you initialize records with subArray.records = {}; , i.e. an object. Then you are trying to "add" another object with subArray.records += item;. This will result in [object Object][object Object] since you are "concatenating" two objects. It goes without saying that concatenating objects as string is wrong. — Felix Kling
– Felix Kling, Commented Oct 7, 2020 at 11:56
There isn't any trace of JSON in the code you posted. JSON is a text representation of some data structure. Your code works with objects and never attempts to produce an external representation of the data they contain. — axiac
– axiac, Commented Oct 7, 2020 at 11:56

firatozcevahir · Accepted Answer · 2020-10-07 11:56:18Z

1

This should work.

function finalArray(data) {
  var nArray = [];
  var subArray = new Object();
  subArray.total = 0;
  subArray.records = []; // records must be array
  subArray.size = 0;
  data.forEach(item => {

    subArray.total += item.Amount;
    subArray.records.push(item); // need to push each item to records array
    subArray.size += 1;
  });
  nArray.push(subArray);
  console.log(nArray);
};

edited Oct 7, 2020 at 11:56

answered Oct 7, 2020 at 11:54

firatozcevahir

9025 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3872094 Over a year ago

Thanks man. This worked great. Can you please let me know where I went wrong?

user3872094 Over a year ago

Ah #@firatozcevahir... Gotcha. Thanks a ton mate...

BadPiggie · Accepted Answer · 2020-10-07 11:55:44Z

1

Code has 2 mistakes.

record should be an array not an object
you need use push method to add data to record. Not addition assignment (+=)

var data = [{
    "Id": "123",
    "Name": "Abc",
    "Amount": 110000
  },
  {
    "Id": "567",
    "Name": "DEF",
    "Amount": 98000
  },
  {
    "Id": "345",
    "Name": "XYZ",
    "Amount": 145000
  }
];

finalArray(data);

function finalArray(data) {
  var nArray = [];
  var subArray = new Object();
  subArray.total = 0;
  subArray.records = [];
  subArray.size = 0;
  data.forEach(item => {

    subArray.total += item.Amount;
    subArray.records.push(item);
    subArray.size += 1;
  });
  nArray.push(subArray);
  console.log(nArray);
};

answered Oct 7, 2020 at 11:55

BadPiggie

6,4391 gold badge17 silver badges37 bronze badges

Comments

Priyanka Rao · Accepted Answer · 2020-10-07 11:59:33Z

1

Change your function to this-

function finalArray(data) {
  var nArray = [];
  var subArray = new Object();
  subArray.total = 0;
  subArray.records=[];
  subArray.size = 0;
  data.forEach(item => {
    
    subArray.total += item.Amount;
    subArray.records += item;    
    subArray.size += 1;
  });
  nArray.push(subArray);
  console.log(nArray);
};

answered Oct 7, 2020 at 11:59

Priyanka Rao

2083 silver badges11 bronze badges

Comments

0stone0 · Accepted Answer · 2020-10-07 11:59:37Z

1

Use an array to hold the original items. Also, you'll need push to add an Object to an Array;

var data = [{
    "Id": "123",
    "Name": "Abc",
    "Amount": 110000
  },
  {
    "Id": "567",
    "Name": "DEF",
    "Amount": 98000
  },
  {
    "Id": "345",
    "Name": "XYZ",
    "Amount": 145000
  }
];

finalArray(data);

function finalArray(data) {

  // New data
  let nArray = {};
  nArray.total = 0;
  nArray.size = 0;
  
  // Create an array inside nArray to hold original items
  nArray.records = [];
  
  data.forEach((item) => {
    nArray.total += item.Amount;
    nArray.size += 1;
    nArray.records.push(item);
  });
 
  console.log(nArray);
};

answered Oct 7, 2020 at 11:59

0stone0

45.5k6 gold badges53 silver badges82 bronze badges

Collectives™ on Stack Overflow

Javascript JSON creation creating an additional object

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related