Linq 2 SQL - A Better way of doing this

Question

I have a repository base class that gets called from my controllers in my mvc application

Each controller gets it own repository

like this

public class ServiceRepository : Bluegrass.Mvc.RepositoryBase<Models.Service>
{
    public ServiceRepository()
    {
        this._db = new iSppms.Models.iSppmsDataContext();
    }
}

And gets used like

internal DataAccess.ServiceRepository repository =
        new iSppms.DataAccess.ServiceRepository();
    public ActionResult Index()
    {
        var viewData = new ViewData.ServiceIndexViewData(
            repository.GetItems<Models.Service>());
        return View(viewData);
    }

Where I am wanting to do is not have to pass the model through as the RepositoryBase is already of type Models.Service

I am looking for a better way to structure this.

public class RepositoryBase<T> where T : class
{
    public DataContext _db;

    public List<T> GetItems<T>() where T : class, Interfaces.IModel
    {
        var table = _db.GetTable<T>();
        var data = table.Where(t => !t.Deleted);

        return data.ToList();
    }

Marc Gravell · Accepted Answer · 2009-03-12 10:55:21Z

1

Can you add the IModel bit to RepositoryBase<T>, and make GetItems<T> non-generic? Note: it is already a bad idea to re-use the generic token T (which is different in GetItems):

public class RepositoryBase<T> where T : class, Interfaces.IModel
{
    public DataContext _db;

    public List<T> GetItems()
    {
        var table = _db.GetTable<T>();
        var data = table.Where(t => !t.Deleted);

        return data.ToList();
    }
}

answered Mar 12, 2009 at 10:55

Marc Gravell

1.1m273 gold badges2.6k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cœur · Accepted Answer · 2019-03-03 16:41:03Z

0

Perhaps this Repository Base Class article could help?

edited Mar 3, 2019 at 16:41

Cœur

39k25 gold badges207 silver badges282 bronze badges

answered Mar 12, 2009 at 11:23

Adrian Grigore

33.4k36 gold badges133 silver badges216 bronze badges

Collectives™ on Stack Overflow

Linq 2 SQL - A Better way of doing this

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related