From arrow function, push object to array

Question

The async/await function search returns an object similar to:

[
  {
    "title":"page title",
    "url":"/page/url/index.html",
    "content":"blah blah blah"
  },
  ...
]

I need to push each object from val into the array, but when I push using:

results = [];
search(input).then(val=> results.push(val));

I get a nested array similar to (I want to the object entries to be top level in the array):

[
  [
    {title:"...", url:"...", content:"..."},
    {title:"...", url:"...", content:"..."},
  ]
]

So I tried a for in the arrow to push each entry in the object into the array, but that didn't seem to work.

results = [];
search(input).then(val=> for(i in val) {results.push(val[i])});

Can't you just use results = val? although I don't really see a purpose of doing this as you'll only be able to access the populated version of results once your promise has resolved, such as in the .then() callback, so you might as well just use val — Nick Parsons
– Nick Parsons, Commented Aug 19, 2020 at 14:27

PeterKA · Accepted Answer · 2020-08-19 14:47:23Z

3

Instead of .push(), use .concat()

results = [];
search(input).then(val=> { results = results.concat(val) });

edited Aug 19, 2020 at 14:47

answered Aug 19, 2020 at 14:42

PeterKA

24.7k5 gold badges28 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ajeet Eppakayala · Accepted Answer · 2020-08-19 14:36:04Z

2

Use spread syntax ...

No For loop needed either.

search(input).then(val=> results = [...results,...val]);

or as @Patrick_Hund suggested

search(input).then(val=> results.push(...val));

here problem is that you are pushing array in to an array.

You need to push the elements of array.

Spreading syntax should fix the issue.

Hope you have clear understanding now.

edited Aug 19, 2020 at 14:36

answered Aug 19, 2020 at 14:27

Ajeet Eppakayala

1,4452 gold badges13 silver badges20 bronze badges

3 Comments

Patrick Hund Over a year ago

push accepts an arbitrary number of arguments, so you can just use the spread operator on val to push to results: search(input).then(val=> results.push(...val));

Patrick Hund Over a year ago

you don't need a for loop here

Jason Over a year ago

@PatrickHund - post yours as an answer, and I'll accept. Thanks.

ffflabs · Accepted Answer · 2020-08-19 14:49:25Z

If you have an array and call a function that will return Promise<array> you don't need to perform any iteration on the result. Concatenate the arrays:

async function getNewData() {
  return Promise.resolve([{
    d: 1
  }, {
    e: 3
  }]);
}

let results = [{
  a: 3
}, {
  b: 4
}];

getNewData().then(newdata => {
  results = results.concat(newdata); 
  // same as results = [...results, ...newdata];

  console.log(results);
});

On the other hand, you could also push using the spread operator

async function getNewData() {
  return Promise.resolve([{
    d: 1
  }, {
    e: 3
  }]);
}

const results = [{
  a: 3
}, {
  b: 4
}];

getNewData().then(newdata => {
  results.push(...newdata); 
  // same as results.push(newdata[0], newdata[1], etc)

  console.log(results);
});

This approach might be confusing as people tend to ignore the variadic nature of Array.prototype.push, but it avoids redeclaring results, so you may declare the target array as const.

Yatrix · Accepted Answer · 2020-08-19 14:28:00Z

1

If you want to use a for loop, you'll have to do

for(var i=0; i < val.length; i++) {
    results.push(val[i])
}

There are more succinct ways to do this (see Patrick Hund's comment), but that's how you do it with a for loop.

answered Aug 19, 2020 at 14:28

Yatrix

13.9k17 gold badges57 silver badges83 bronze badges

Collectives™ on Stack Overflow

From arrow function, push object to array

4 Answers 4

Comments

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related