Query failed data not inserted to the DB

Question

Those are the fields on my DB

partamento int
codigocurso int
diurno int
contacto int
pos_laboral int
contacto2 int
proc_por int

I’ve been trying to fix this error since yesterday but I cannot figure out where is the error. **

foreach ($diurno as $userId) {
        $data .= "(".$id.",".$grdid.",".$userId.",".$contacto.",".$pos_laboral.",".$contacto2.",".$idd.")";
    }
    
    $data = rtrim($data, ',');
    $sql = "insert into cursosprogramas (departamento, codigocurso, diurno, contacto, pos_laboral, contacto2, proc_por) values (".$data.");";
    echo $sql;

the error

insert into cursosprogramas (departamento, codigocurso, diurno, contacto, pos_laboral, contacto2, proc_por) values ((100,120,7,646,5,363,2)(100,120,4,646,5,363,2));Query failed.

Also, you should also learn about Prepared Statements with parameterized queries. — GrumpyCrouton
– GrumpyCrouton, Commented Jul 1, 2020 at 11:37

GrumpyCrouton · Accepted Answer · 2020-07-01 12:53:59Z

2

You are missing a comma between data sets, and you also don't need parenthesis around them all. You are already using rtrim() to remove the very last comma, but you aren't actually adding the comma at the end of the data set.

foreach ($diurno as $userId) {
    
    //add a comma at the end
    //note you can write variables directly into a string that is wrapped with double quotes
    $data .= "('$id', '$grdid', '$userId', '$contacto', '$pos_laboral', '$contacto2', '$idd'),";
}

//this gets rid of the very last comma in the string
$data = rtrim($data, ',');

//remove parenthesis around `$data`
$sql = "insert into cursosprogramas (departamento, codigocurso, diurno, contacto, pos_laboral, contacto2, proc_por) values {$data};";
echo $sql;

NOTE: Little Bobby says this code MAY be at risk for SQL Injection Attacks depending on how the variables inside of $data are created. Learn about Prepared Statements with parameterized queries.

edited Jul 1, 2020 at 12:53

answered Jul 1, 2020 at 11:45

GrumpyCrouton

8,6367 gold badges37 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

16 Comments

GrumpyCrouton Over a year ago

@HQweb Glad that I could help

HQweb Over a year ago

I added more columns on my table and I tried to insert data on the table and I got query failed, so I tried to troubleshoot and I got this: postgres=# insert into cursosprogramas (departamento,codigocurso,curso,codigo,disciplina,legenda,ano,r,t,tp,pl,ts,total,ms,diurno,contacto,pos_laboral,contacto2,proc_por)values (100,2121,Medicina,5235,sgsgs, s,1º,1º,4,4,4,4,4, 4,5,646464,5,6363, 2),(100,2121,Medicina,5235,sgsgs, s,1º,1º,4,4,4,4,4, 4,4,646464,5,6363, 2); ERROR: syntax error at or near "§"LINE 1: ...roc_por) values (100,2121,Medicina,5235,sgsgs, s,1§,1§,4,4,4...

HQweb Over a year ago

Those are the fields on my DB departamento int codigocurso int curso text codigo int disciplina text legenda text ano text r text From column t to column proc_por they are integer

GrumpyCrouton Over a year ago

@HQweb Try my update, I removed the single quotes without thinking about it.

GrumpyCrouton Over a year ago

@HQweb Shouldn't it just be $userId?

|

Alex Funk · Accepted Answer · 2020-07-01 11:45:27Z

1

You need a comma between the value tuples. Try a comma at the end of line two like this:

foreach ($diurno as $userId) {
$data .= "(".$id.",".$grdid.",".$userId.",".$contacto.",".$pos_laboral.",".$contacto2.",".$idd."),";
}

$data = rtrim($data, ',');
$sql = "insert into cursosprogramas (departamento, codigocurso, diurno, contacto, pos_laboral, contacto2, proc_por) values (".$data.");";
echo $sql;

answered Jul 1, 2020 at 11:45

Alex Funk

3562 silver badges7 bronze badges

1 Comment

GrumpyCrouton Over a year ago

This answer currently fails if any of the values are strings with a space in it

Collectives™ on Stack Overflow

Query failed data not inserted to the DB

2 Answers 2

16 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

16 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related