Add function in a PowerShell script

Question

I am trying to incorporate this function to my script but it shows me errors If I add any other code before this function as seen below. I enclosed the parameter in {} and the error no longer shows but it messes up my output since the parameters are no longer being defined. I have other code that needs to run and before this part of the script executes. You can see adding any other code before this function causes errors.

So I don't know how to include this part of the script with my other code and have it work. Any Help?

Please avoid using pictures for code. It makes it impossible to copy it. — ArcSet
– ArcSet, Commented May 28, 2020 at 20:18
Take the Get-TraceRoute code and convert it into a function. — FoxDeploy
– FoxDeploy, Commented May 28, 2020 at 20:21

ArcSet · Accepted Answer · 2020-05-28 20:27:33Z

7

Place the script into a function. You just surround the code in a function.

Function Get-Traceroute{
    [CmdletBinding()]
    param(
        [Parameter(Mandatory=$True,ValueFromPipeline=$True)]
        [String]$Target,

        [Parameter(ValueFromPipeline)]
        [Alias("c")]
        [ValidateRange(5,100)]
        [int]$PingCycles = 10, #Default to 10 pings per hop; minimum of 5, maximum of 100

        [Parameter(ValueFromPipeline)]
        [Alias("b")]
        [ValidateRange(32,1000)]
        [int]$BufLen = 32, #Default to 32 bytes of data in the ICMP packet, maximum of 1000 bytes

        [Parameter(ValueFromPipeline)]
        [Alias("s")]
        [IPAddress]$DNSServer = $Null,

        [Parameter(ValueFromPipeline)]
        [Alias("f")]
        [String]$Filename = "Traceroute_$Target"

    )
    Function script:Set-Variables {
    ...more code here...
}

Then you can just call the function Get-TraceRoute -Target 8.8.8.8

edited May 28, 2020 at 20:27

answered May 28, 2020 at 20:24

ArcSet

6,9401 gold badge24 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Nebelz Cheez Over a year ago

i will test everything and confirm. 5 mins please :)

FoxDeploy Over a year ago

Great minds think exactly alike at the exact same time :)

FoxDeploy · Accepted Answer · 2020-05-29 13:45:45Z

5

Decorators and parameters need to be placed at the top of a script.

So, your parameter declaration (the [CmdletBinding] to then end of the param() block) should be at the top of the script. Then you can include that other function in it's entirety. For instance, it would look like...

 [Parameter(ValueFromPipeline)]
    [Alias("s")]
    [IPAddress]$DNSServer = $null,

    [Parameter(ValueFromPipeline)]
    [Alias("f")]
    [String]$Filename = "Traceroute_$Target"

    )#end of your original param block

Function Get-TraceRoute{
    param(
    [Parameter(Mandatory=$True,ValueFromPipeline=$True)]
    [String]$Target,
#. omitting 230 lines.#

$PerTraceArr | Format-Table -Autosize
}#end of Get-TraceRoute

You would then end the script like so:

}#end of Get-TraceRoute

Get-TraceRoute -Target $ip #or whichever params you want to pass in to your `.ps1` file.

edited May 29, 2020 at 13:45

answered May 28, 2020 at 20:24

FoxDeploy

13.8k3 gold badges42 silver badges58 bronze badges

2 Comments

ArcSet Over a year ago

you and me posted the exact same thing lol. At the exact same time

Nebelz Cheez Over a year ago

yeah putting it at the top seems to be working.. I will test everything and confirm in 2 mins

Collectives™ on Stack Overflow

Add function in a PowerShell script

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related