Adding items in an array of strings each one at a time

Question

I have this line of code:

invoke-command -Session $s -scriptblock {Set-Adgroup  $using:ListBox1.SelectedItem -add @{proxyaddresses="$using:smtps"}}

$s is legitimate session, $listbox.selecteditem is for example a dist group called Old-Sales-Users , and $smtps is a string array like so: @smtps = "smtp:[email protected]", "smtp:[email protected]", "smtp:[email protected]"

i want to invoke this command so i can add those smtps to the proxyaddresses of the dist group. but the way this works here is that its adding the 3 strings to the same line so i get one line proxyaddress with "smtp:[email protected] smtp:bla2@bla...." i want it to create 3 seperate lines (or more if there's more in that array) meaning like an ENTER is pressed after each item in the array... my second question is if thats the correct way to be doing this? because i actually open 3 invoke commands is there a way using 1 invoke command to add all that array to the proxyaddress?

Thank you

it will throw an error: Invalid type 'System.Management.Automation.PSObject'. Parameter name: proxyaddresses + CategoryInfo : InvalidArgument: (OldIT:ADGroup) [Set-ADGroup], ArgumentException + FullyQualifiedErrorId : ActiveDirectoryCmdlet:System.ArgumentException,Microsoft.ActiveDirectory.Management.Commands.SetADGroup + PSComputerName : dc01 — Shahar Weiss
– Shahar Weiss, Commented May 23, 2020 at 10:39
That's a problem with the object referenced by $using:ListBox1.SelectedItem, maybe try $GroupName = $ListBox1.SelectedItem.DistinguishedName and then pass $using:GroupName to Set-ADGroup inside the remote script block — Mathias R. Jessen
– Mathias R. Jessen, Commented May 23, 2020 at 10:41
that could work i guess but i need to change more code lines for that cuz $listbox1.selecteditems are just strings when we get here, is there no way to pass array of strings and reach each of them for itself? im guessing a solution would be a loop going inside the array and invoking command for every item but thats like an overkill ithink — Shahar Weiss
– Shahar Weiss, Commented May 23, 2020 at 10:52

Theo · Accepted Answer · 2020-05-23 14:37:33Z

3

To post my comment as answer:

Although this is not clear in the documentation for Set-ADUser, adding items to the ProxyAddresses list needs the array of new smtp addresses to be strongly typed, so every item in the array is of type [string]

This means the array to add needs to be casted with [string[]]

You can see the difference like this:

$arr1 = 'an','array','can','also','contain','numbers',1,2,3
$arr1.GetType().FullName  # --> System.Object[]

[string[]]$arr2 = 'an','array','can','also','contain','numbers',1,2,3
$arr2.GetType().FullName  # --> System.String[]

In your case, use

-Add @{proxyaddresses= [string[]]$using:smtps}

answered May 23, 2020 at 14:37

Theo

61.9k8 gold badges28 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Robert Cotterman Over a year ago

Or when he sets smtps, he should set it with the [string[]] tag...Powershell is a weakly typed language, meaning it will attempt to detect the type of variable you are setting, (as opposed to strongly typed). Sometimes it get's it wrong, so identifying it yourself can remove any possible errors that might arise..Because his example starts with @smtps = "bla" the @smtps = might be confusing powershell.

Collectives™ on Stack Overflow

Adding items in an array of strings each one at a time

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related