JavaScript/jQuery: replace part of string?

Question

With text like this:

<div class="element">
<span>N/A, Category</span>
</div>

I want to get rid of every occurrence of N/A.

Here is my attempt:

$('.element span').each(function() {
        console.log($(this).text());
        $(this).text().replace('N/A, ', '');
    });

The logged text is the text inside of the span so the selector is okay.

What am I doing wrong here?

replace returns a string, it does not perform in place changes. And even then, the text would be set to the element automatically. — Felix Kling
– Felix Kling, Commented May 30, 2011 at 13:58

dota2pro · Accepted Answer · 2019-10-01 19:45:29Z

105

You need to set the text after the replace call:

$('.element span').each(function() {
  console.log($(this).text());
  var text = $(this).text().replace('N/A, ', '');
  $(this).text(text);
});

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div class="element">
  <span>N/A, Category</span>
</div>

Here's another cool way you can do it (hat tip @Felix King):

$(".element span").text(function(index, text) {
    return text.replace("N/A, ", "");
});

edited Oct 1, 2019 at 19:45

dota2pro

7,9548 gold badges51 silver badges87 bronze badges

answered May 30, 2011 at 13:56

Andrew Whitaker

126k32 gold badges296 silver badges308 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Felix Kling Over a year ago

Or pass a function: $(this).text(function(i, text) { return text.replace(...);});

Andrew Whitaker Over a year ago

@Felix: Good call, I always forget about that version.

kapa Over a year ago

+1 for the second version, upvote one of @Felix 's answers to transfer it to him :).

Andrew Whitaker Over a year ago

@bazmegakapa: Haha, yep. I've given @Felix plenty of upvotes already :)

kapa Over a year ago

@Andrew I guess most of us have :).

Codler · Accepted Answer · 2011-05-30 13:56:39Z

14

It should be like this

$(this).text($(this).text().replace('N/A, ', ''))

answered May 30, 2011 at 13:56

Codler

11.3k6 gold badges55 silver badges66 bronze badges

Collectives™ on Stack Overflow

JavaScript/jQuery: replace part of string?

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related