How to correctly use Android View Binding in DialogFragment?

Question

What is correct way of using Android View Binding in DialogFragment()?

Official documentation mentions only Activity and Fragment: https://developer.android.com/topic/libraries/view-binding

hamrosvet · Accepted Answer · 2020-12-10 09:27:54Z

58

Use inflate(LayoutInflater.from(context)) instead. And use binding.root to set the builder view.

Also, as Google suggests, it's best practice to set the binding instance to null at onDestroyView() when using fragments: https://developer.android.com/topic/libraries/view-binding#fragments

Example:

class ExampleDialog : DialogFragment() {

    private var _binding: DialogExampleBinding? = null
    // This property is only valid between onCreateDialog and
    // onDestroyView.
    private val binding get() = _binding!!

    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
        _binding = DialogExampleBinding.inflate(LayoutInflater.from(context))
        return AlertDialog.Builder(requireActivity())
            .setView(binding.root)
            .create()
    }
    
    override fun onDestroyView() {
        super.onDestroyView()
        _binding = null
    } 
}

edited Dec 10, 2020 at 9:27

answered Apr 30, 2020 at 3:24

hamrosvet

1,19813 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Mehmed Over a year ago

This is recommended to prevent crashes but what happens if binding is used after it is set to null? I think it will crash, which means private val binding get() = _binding!! makes no sense at all. Am I missing something?

Nino DELCEY Over a year ago

You shouldn't use the view once it reaches the onDestroyView life cycle.

Nino DELCEY Over a year ago

Also, it is a better pratice to use your binding as a local variable. No need to override onDestroyView in this case ! :)

The Dongster Over a year ago

This will crash sometimes as @Mehmed said.

CoolMind Over a year ago

@IgorGanapolsky, yes. When a fragment recreates a view, it's _binding receives a new value. To detect where a view is destroyed, check _binding == null (for instance, after long loading operations).

|

Collectives™ on Stack Overflow

How to correctly use Android View Binding in DialogFragment?

1 Answer 1

8 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related