Java replace a character in a string

Question

I am writing a method to replace all vowels in a string with a given character, but it does not work for strings with more than one vowel. It works for "heel" but not for "hello". Please help. My code below:

public Boolean isVowel(char ch){

        char ch2 = Character.toLowerCase(ch); 
        char[] vowels = {'a', 'e', 'i', 'o', 'u'};

        for(int i = 0; i < vowels.length; i++){
            if (ch2 == vowels[i]) {
                return true;
            }
        }
            return false;
    }

    public String replaceVowels(String phrase, char ch){
        String newP = "";
        for(int i = 0; i < phrase.length(); i++){  
            char c = phrase.charAt(i);
            Boolean vowel = isVowel(c);

            if(vowel){ 
               newP = phrase.replace(c, ch);
            }
        }

        return newP;
    }

Michael Michailidis · Accepted Answer · 2020-04-04 13:01:36Z

6

public String replaceVowels(final String phrase,final String ch) {
    return phrase.replaceAll("[aeiou]", ch);
}

edited Apr 4, 2020 at 13:01

Michael Michailidis

1,0621 gold badge10 silver badges24 bronze badges

answered Apr 4, 2020 at 12:39

Alex Sveshnikov

4,3391 gold badge13 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marc · Accepted Answer · 2020-04-04 12:55:17Z

2

Here is one way to replace all vowels in a string with an java char. The (?i) is to make it case insensitive. The "" +ch gets a string from the char.

String str = "hEllo";
char ch = 'X';
str = str.replaceAll( "(?i)[aeiou]", "" +ch );

Could also be more explicit with case like:

String str = "hEllo";
char ch = 'X';
str = str.replaceAll( "[aeiouAEIOU]", "" +ch );

answered Apr 4, 2020 at 12:55

Marc

942 bronze badges

Comments

Vikas · Accepted Answer · 2020-04-04 12:49:35Z

1

Your problem is newP = phrase.replace(c, ch); You are assigning a last value.

String newP = phrase;
        for(int i = 0; i < phrase.length(); i++){
            char c = phrase.charAt(i);
            Boolean vowel = isVowel(c);

            if(vowel){
                newP = newP.replace(c, ch);
            }
        }

Better solution as answered by Alex just add String,

phrase.replaceAll("[aeiou]", ""+ch);

answered Apr 4, 2020 at 12:49

Vikas

7,2214 gold badges30 silver badges46 bronze badges

Collectives™ on Stack Overflow

Java replace a character in a string

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related