for-loop in loop syntax error: unexpected end of file

Question

I'm trying to run a program called aldy on several .json files with a list of items (A, B, C, D)

I want to use the file name without the extension
like bob in bob.json, amy in amy.json

The desired output would be
bob.a.txt, bob.b.txt, ...
amy.a.txt, amy.b.txt, ...

The code I have

#!/usr/bin/env bash

LIST=('A' 'B' 'C' 'D')

for file in *.json; do
     filename=${file%%.*}       
    for i in "${LIST}"; do
        outfile = $filename + ".${i}.txt"
        aldy -g ${i} -o $outfile $file
    done
done

However, I got error message and I don't really know how to fix this.

syntax error: unexpected end of file

Any help would be greatly appreciated
Thanks in advance.

Copy and paste your script to shellcheck.net

oguz ismail
– oguz ismail

2020-04-02 15:38:44 +00:00
Commented Apr 2, 2020 at 15:38 — oguz ismail
– oguz ismail, Commented Apr 2, 2020 at 15:38
Thank you so much!! This is really helpful!

Aly
– Aly

2020-04-02 16:09:08 +00:00
Commented Apr 2, 2020 at 16:09 — Aly
– Aly, Commented Apr 2, 2020 at 16:09

Quasímodo · Accepted Answer · 2020-04-02 15:53:07Z

1

Make the following corrections:

for i in "${LIST[@]}"; do. That's how you get all elements of an array.
outfile=${filename}.${i}.txt.
1. There may be no spaces around = in assignments.
2. Concatenating variables is done by placing them next to one another. You can use braces (as in ${expandthis}butnotthis) to delimit them, but in your case simply $filename.$i.txt would do (. serves as delimiter).
aldy -g "$i" -o "$outfile" "$file". Quote your variables when expanding them. If you always do it, either the quotes will be redundant, or (in most cases) they will prevent problems caused by word splitting and globbing.

answered Apr 2, 2020 at 15:53

Quasímodo

4,09418 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Aly Over a year ago

Thank you so much!! All the explanation makes it very clear :)

Collectives™ on Stack Overflow

for-loop in loop syntax error: unexpected end of file

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related