PHP Update query

Question

I have written a PHP class which will update 4 fields of a certain row in a table. The row is decided by a session var 'user' (which is unique). It's not working, but i'm not sure if it is because of the query or the class itself. So i'm first gonna ask you guys if there are any errors in this query (there probaply are) and when the query is correct, i'll see if the class itself has errors as well.

Query:

UPDATE tblRegistratie(lengte, gewicht, bmi geluk) WHERE `gebruikersnaam` = '" . $_SESSION['regain-user'] . "'
        VALUES(
        '".mysqli_real_escape_string($conn, $this->Lengte_update)."',
        '".mysqli_real_escape_string($conn, $this->Gewicht_update)."',
        '".mysqli_real_escape_string($conn, $this->BMI_update)."',
        ''".mysqli_real_escape_string($conn, $this->Geluk_update)."',
        );

Based on how the SO syntax highlighter is choking on unclosed quotes, can you post the query in correct context from your code? — Michael Berkowski
– Michael Berkowski, Commented May 18, 2011 at 17:16
bmi geluk - if that's one column, you need to escape it with backticks (the space might break the query) — Piskvor left the building
– Piskvor left the building, Commented May 18, 2011 at 17:18

Michael Berkowski · Accepted Answer · 2011-05-18 17:18:04Z

2

The quotes look funny here, but I think your problem is a trailing comma , after the last param:

''".mysqli_real_escape_string($conn, $this->Geluk_update)."',
                                                          ^^^^^

answered May 18, 2011 at 17:18

Michael Berkowski

271k47 gold badges450 silver badges395 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Naftali · Accepted Answer · 2011-05-18 17:15:57Z

1

Last line:

    ''".mysqli_real_escape_string($conn, $this->Geluk_update)."',
    ^^//fix the double qoute and make it single '

answered May 18, 2011 at 17:15

Naftali

147k41 gold badges247 silver badges304 bronze badges

1 Comment

Michael Berkowski Over a year ago

Ah yes, looks like two problems.

Joe Phillips · Accepted Answer · 2011-05-18 17:22:11Z

1

This is what an UPDATE query should look like.

UPDATE tblRegistratie
SET lengte=mysqli_real_escape_string($conn, $this->Lengte_update),
    gewicht=mysql...etc
    `bmi geluk`=...etc
WHERE `gebruikersnaam` = '" . $_SESSION['regain-user'] . "'

Yours looks nothing like that.

answered May 18, 2011 at 17:22

Joe Phillips

51.5k33 gold badges109 silver badges167 bronze badges

1 Comment

Michael Berkowski Over a year ago

Phillips Indeed - I missed that entirely.

Xint0 · Accepted Answer · 2011-05-18 17:23:37Z

0

The correct syntax for UPDATE in MySQL would be something like::

$sql = "UPDATE tblRegistratie SET
    lengte = '".mysqli_real_escape_string($conn, $this->Lengte_update)."',
    gewicht = '".mysql_real_escape_string($conn, $this->Gewicht_update)."',
    bmi = '".mysql_real_escape_string($conn, $this->BMI_update)."',
    geluk = '".mysqli_real_escape_string($conn, $this->Geluk_update)."'
    WHERE gebruikersnaam = '". $_SESSION['regain-user'];

answered May 18, 2011 at 17:23

Xint0

5,4192 gold badges30 silver badges29 bronze badges

Comments

Luke Sneeringer · Accepted Answer · 2011-05-18 17:22:30Z

0

You need to have your where clause after the values you're setting. Also, it sounds like you have some punctuation issues.

Consider the following rewrite for general easier-to-read goodness:

$query = 'UPDATE tblRegistratie
    SET `lengte` = "' . mysqli_real_escape_string($conn, $this->Lengte_update) . '",
        `gewicht` = "' . mysqli_real_escape_string($conn, $this->Gewicht_update) . '",
        `bmi` = "' . mysqli_real_escape_string($conn, $this->BMI_update) . '",
        `geluk` = "' . mysqli_real_escape_string($conn, $this->Geluk_update) . '"
    WHERE `gebruikersnaam` = "' . $_SESSION['regain-user'] . '"
';

Also, functions like sprintf() can be your friend. :)

$query = sprintf('UPDATE `tblRegistratie`
     SET `lengte` = "%s",
         `gewicht` = "%s",
         `bmi` = "%s",
         `geluk` = "%s"
     WHERE `gebruikersnaam` = "%s";', 
     mysqli_real_escape_string($conn, $this->Lengte_update),
     mysqli_real_escape_string($conn, $this->Gewicht_update),
     mysqli_real_escape_string($conn, $this->BMI_update),
     mysqli_real_escape_string($conn, $this->Geluk_update),
     $_SESSION['regain-user']
);

answered May 18, 2011 at 17:22

Luke Sneeringer

9,4382 gold badges39 silver badges32 bronze badges

2 Comments

Luke Sneeringer Over a year ago

You're right, I did. Thanks -- corrected. That thing was tough to write inside a text box; I should have used a real text editor. :)

Kevin Verhoeven Over a year ago

I edited the query and it now runs in sql. However, the class still doesn't work so it means there's also a problem with it. It doesn't give any errors either, that kinda bothers me. I'll be posting a new question about it. Thanks for the help!

Lightness Races in Orbit · Accepted Answer · 2011-05-18 17:23:08Z

0

PHP

On the last line you have two initial single quotes.

Fix:

''".mysqli_real_escape_string($conn, $this->Geluk_update)."',

becomes

'".mysqli_real_escape_string($conn, $this->Geluk_update)."',

MySQL

Additionally, your UPDATE syntax appears to be completely invalid. Have a read through the documentation.

answered May 18, 2011 at 17:23

Lightness Races in Orbit

387k77 gold badges670 silver badges1.1k bronze badges

Collectives™ on Stack Overflow

PHP Update query

6 Answers 6

Comments

1 Comment

1 Comment

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

1 Comment

1 Comment

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related