PHP WHILE loop mysteriously not producing any output

Question

Code first, explanation after:

$result = mysql_query("INSERT INTO messages (...) VALUES (...)") or die(mysql_error());
            $rowID = mysql_insert_id();         
            if($result) {                                   
                $query = mysql_query("
                SELECT ... LIMIT 1");

                while ($row = mysql_fetch_array($query)) :
                    $message_id = stripslashes($row["m_id"]);
                    $message_postedby = stripslashes($row["u_name"]);
                    $message_text = stripslashes($row["m_text"]);
                    $date = date('F d, Y \a\t g:iA', strtotime($row["m_date"]));
                    ?>
                <div class="wall_message" id="<?= $message_id ?>">
                    <div class="author"><?= $message_postedby ?></div>
                    <div class="message"><?= $message_text ?></div>
                    <div class="date"><?= $date ?></div>
                </div>
                <?php
                endwhile;
                } ?>

What I'm doing:

Insert new row into database
Store ID of inserted row in variable $rowID
If insert was successful, query the database to retrieve that row along with any other related information from other tables
Store values from the row in variables
Print the divs containing that info

All of this is being called from a jQuery function, so I'm expecting that all of my HTML will be returned, but nothing is being returned inside the WHILE loop. I can echo text before and after it, and I see it just fine, but nothing inside the loop will print, and I just can't see my mistake. Not getting any errors either.

Thanks.

You're missing a quote mark after the SQL on line 1.

Rafe Kettler
– Rafe Kettler

2011-05-18 03:21:08 +00:00
Commented May 18, 2011 at 3:21 — Rafe Kettler
– Rafe Kettler, Commented May 18, 2011 at 3:21

dtbarne · Accepted Answer · 2011-05-18 03:20:29Z

6

mysql_fetch_array() doesn't take a query, it takes a resource (result).

$result = mysql_query($query);
while ($row = mysql_fetch_assoc($result)) {

Also worth nothing that if you are only accessing the associative keys from the result, you should use mysql_fetch_assoc() instead.

answered May 18, 2011 at 3:20

dtbarne

8,2505 gold badges47 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user743234 Over a year ago

In his code, $query means $result as it's named incorrectly :)

user743234 Over a year ago

He used mysql_fetch_array($query) with $query = mysql_query("<statement>"), so $query is a result resource, not a query string.

Collectives™ on Stack Overflow

PHP WHILE loop mysteriously not producing any output

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related