How to push into an array using nodejs

Question

I am trying to push the file into the array named FileName however when I try to console.log(FileName) all I get is the empty array! Any input would be greatly appreciated!


const fs = require("fs");
const mm = require("music-metadata");
const dataFolder = "../../Songs";
const util = require("util");
//requiring path and fs modules
const path = require("path");
let FileName = [];
fs.readdir(dataFolder, (err, files) => {
  files.forEach(e => {
    return mm.parseFile(`../../Songs/${e}`).then(metadata => {
      // console.log(`../..Songs/${e}`);
      FileName.push(e);
      // console.log(
      //   util.inspect(metadata.common.title, {
      //     showHidden: false,
      //     depth: null
      //   })
      // );
    });
  });
});
console.log(FileName);
// mm.parseFile(
//   "/Users/nathangriffith/Desktop/dashboard/Songs/04 Smoke and Mirrors.m4a"
// )
//   .then(metadata => {
//     console.log(
//       metadata.native.iTunes[0].value
//     );
//   })
//   .catch(err => {
//     console.error(err.message);
//   });

Wait, do you just need the value from the readdir call in the FileName array? That's what you're doing when you call FileName.push(e);. However, I'll post an answer assuming that you need metdata in the FileName array... — dmitrydwhite
– dmitrydwhite, Commented Jan 30, 2020 at 0:56

dmitrydwhite · Accepted Answer · 2020-01-30 01:04:33Z

1

Assuming that you need metadata in your FileName array:

const files = readdirSync(dataFolder); // Now files is an array of file names

Promise
  .all(files.map(file => mm.parseFile(`../../Songs/${file}`)
  .then(metadataArr => {
    console.log(metadataArr); // This should be your parsed metdatas
  });

answered Jan 30, 2020 at 1:04

dmitrydwhite

8364 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

score 0 · Accepted Answer · 2020-01-30 00:35:55Z

0

You are running an async function and expecting it to complete before the next line (console.log) runs. The log runs during the runtime of readdir, and therefore prints the value of FileName as it is before readdir changes it.

You can either change the program to use await/async correctly, or implement readdirSync instead.

edited Jan 30, 2020 at 0:35

answered Jan 30, 2020 at 0:30

user9761835

Collectives™ on Stack Overflow

How to push into an array using nodejs

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related