JS output from data structure to table

Question

Data Structure

var X = {
   a: [{name:"john", phone:777},{name:"john", phone:777},{name:"john", phone:777}],
   b: [{name:"john", phone:777},{name:"john", phone:777},{name:"john", phone:777}],
   c: [{name:"john", phone:777},{name:"john", phone:777},{name:"john", phone:777}],
   d: [{name:"john", phone:777},{name:"john", phone:777},{name:"john", phone:777}]
}

Function

function showTable(trnum,X,a) {
    var Tablecode = "<table><tbody>";
    for (var i=0; i< X.a.length;i++) {
        for (var j=0; j< trnum; j++) {
            Tablecode += "<tr><td>"+X.a[i].name+"</td><td>"+X.a[i].phone+"</td></tr>";
        }
    }
    Tablecode += "</tbody></table>";
    $("#elem").append(Tablecode);
}

Markup

<body>
    <button onclick="showTable(4,X,"a");"></button>
    <div id="elem">
    </div>
</body>

I'm trying to output data to table according to letter. one object on one table row.(all objects in table within one letter). this code doesn't work- unexpected token "}". oddly enough, it points to <div id="elem"> line. but there's no such character! How can I fix this?

UPDATE: thanks, error disappeared... but it outputs the whole structure, how do I make it output only 'a' objects?

Community · Accepted Answer · 2017-05-23 12:19:58Z

1

<button onclick="showTable(4,X,"a");"></button>

should be like that (doublequotes):

<button onclick="showTable(4,X,'a');"></button>

Compare this one to yours (see .a and [a])

for (var i=0; i< X[a].length;i++){
 for (var j=0; j< trnum; j++){
 Tablecode += "<tr><td>"+X[a][i].name+"</td><td>"+X[a][i].phone+"</td></tr>";
 }

}

Feature reading about javascript notations

edited May 23, 2017 at 12:19

CommunityBot

11 silver badge

answered May 11, 2011 at 17:26

pmaruszczyk

2,1652 gold badges25 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

DrStrangeLove Over a year ago

thanks, error disappeared... but it outputs the whole structure, how do i make it output only 'a' objects??

pmaruszczyk Over a year ago

12 beacuse X[a]length(=3) * trnum (=4) = 12 You have 2 loops

DrStrangeLove Over a year ago

i see.. is there a chance to fix this?? to get only 3 (under 'a')johns??

pmaruszczyk Over a year ago

yes, remove for (var j=0; j< trnum; j++){ and } after Tablecode += ... . When you done this you can also change: showTable(4,X,'a'); to showTable(X,'a'); and function showTable(trnum,X,a) { for function showTable(X,a) {

DrStrangeLove Over a year ago

thanks a lot!! you nailed it!! :) sorry but i have last question: how to disable button after first click?? to make it clickable but unexecutable after first click??

|

josh.trow · Accepted Answer · 2011-05-11 17:29:35Z

0

From tossing your code into a fiddle and getting it to run, I noticed that your button is a failure point. You have to surround the 'a' with SINGLE quotes.

http://jsfiddle.net/YaZp2/1/

EDIT: Also, edited the output code added the ability to actually see if it works.

answered May 11, 2011 at 17:29

josh.trow

4,90123 silver badges31 bronze badges

Comments

James · Accepted Answer · 2011-05-11 17:29:40Z

0

Double quotes used to delimit the onclick and also the params within.

Try

<button onclick="showTable(4,X,'a');">

answered May 11, 2011 at 17:29

James

22.4k5 gold badges29 silver badges44 bronze badges

Collectives™ on Stack Overflow

JS output from data structure to table

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related