Rails - exclude a specific element from an array

Question

I have method in my model that returns an array called all_items I'm trying to filter out the insurance item if the duration is more than 365 days so as below:

  def available_items
    return all_items - [all_items.insurance] if duration >= 365

    all_items
  end

But I'm still getting insurance even if the duration is more than 365. Tested it in the console and insurance comes up as part of the array. What did I do wrong here?

"I have method in my model" – show it, please. Since this is a Rails question I suspect that you retrieve the array from your database? If so, you'd typically use a query to specify the records you're interested in, probably via a scope. — Stefan
– Stefan, Commented Jan 8, 2020 at 16:14
Well, the addition with the id 28 in the one array is not the same as in the other array, they have different object ids. Where do these arrays come from? — spickermann
– spickermann, Commented Jan 8, 2020 at 16:14

David · Accepted Answer · 2020-01-08 16:40:53Z

1

An alternative is to simply negate your scope:

def available_items
   duration >= 365 ? Addition.where.not(id: Addition.insurance) : Addition.all
end

Though it might be more efficient to create a negative scope on your model, eg:

scope :not_insurance, -> { where.not(name: 'insurance' }

and then change the available_items to something like:

duration >= 365 ? Addition.not_insurance : Addition.all

answered Jan 8, 2020 at 16:40

David

3,6203 gold badges23 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

gabrielhilal · Accepted Answer · 2020-01-08 16:16:10Z

1

Addition:0x00007f8655402300 is not the same as Addition:0x00007f86526cc728

You could check the name instead of the whole object:

  def available_items
    return all_items.reject { |i| i[:name] == "insurance" } if duration >= 365

    all_items
  end

answered Jan 8, 2020 at 16:16

gabrielhilal

10.8k8 gold badges56 silver badges83 bronze badges

Comments

mechnicov · Accepted Answer · 2020-01-08 16:16:52Z

1

It looks that it is not Array but Relation and insurance is the scope.

So you can do something like

all_items.where.not(name: 'insurance')

answered Jan 8, 2020 at 16:16

mechnicov

16.2k5 gold badges48 silver badges69 bronze badges

Collectives™ on Stack Overflow

Rails - exclude a specific element from an array

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related