Javascript filter method, Remove all Items with matching values in array

Question

I'm trying to remove all items if they match with array values but it's removing only one item. How can i remove all items with filter method or what is the best way to achieve this.

let data = [
    {
        id: '1',
        title: 'ABC'
    },
    {
        id: '2',
        title: 'DEF'
    },
    {
        id: '3',
        title: 'GHI'
    },
    {
        id: '4',
        title: 'JKL'
    },
    {
        id: '5',
        title: 'MNO'
    }
]


data = data.filter(post => {

    let remove = ['2', '4', '5']

    for(let i = 0; i < remove.length; i++) {
        return post.id !== remove[i]
    }

})

console.log(data)

Thanks

Ivan Karaman · Accepted Answer · 2019-12-28 12:22:31Z

3

you should return false if you want to remove item from array

let data = [
    {
        id: '1',
        title: 'ABC'
    },
    {
        id: '2',
        title: 'DEF'
    },
    {
        id: '3',
        title: 'GHI'
    },
    {
        id: '4',
        title: 'JKL'
    },
    {
        id: '5',
        title: 'MNO'
    }
]
let remove = ['2', '4', '5']

data = data.filter(post => {
return !remove.includes(post.id);
})

console.log(data)

answered Dec 28, 2019 at 12:22

Ivan Karaman

1,2341 gold badge7 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Larry N · Accepted Answer · 2019-12-28 12:32:25Z

3

All the notice are in the snippet's comment

let data = [ { id: '1', title: 'ABC' }, { id: '2', title: 'DEF' }, { id: '3', title: 'GHI' }, { id: '4', title: 'JKL' }, { id: '5', title: 'MNO' } ]

const remove = ['2', '4', '5']

// `indexOf` is from ES5
data = data.filter(post => remove.indexOf(post.id) === -1)
console.log(data)

// `includes` is from ES7
data = data.filter(post => !remove.includes(post.id))
console.log(data)

// this will recreate the array ['2', '4', '5'] 5 times
data = data.filter(post => !['2', '4', '5'].includes(post.id))
console.log(data)

answered Dec 28, 2019 at 12:32

Larry N

2811 silver badge11 bronze badges

Comments

StepUp · Accepted Answer · 2019-12-28 12:33:54Z

2

There is no need to use for loop inside of filter.

Instead it is possible to use some method inside of filter. The some method checks whether at least one element satisfies condition inside of provided function. So unnecessary iteration will be avoided:

data.filter(f => !remove.some(s => s == f.id))

An example:

let data = [
    {
        id: '1',
        title: 'ABC'
    },
    {
        id: '2',
        title: 'DEF'
    },
    {
        id: '3',
        title: 'GHI'
    },
    {
        id: '4',
        title: 'JKL'
    },
    {
        id: '5',
        title: 'MNO'
    }
]

let remove = ['2', '4', '5']

console.log(data.filter(f => !remove.some(s => s == f.id)));

edited Dec 28, 2019 at 12:33

answered Dec 28, 2019 at 12:26

StepUp

38.5k16 gold badges95 silver badges159 bronze badges

Comments

C.OG · Accepted Answer · 2019-12-28 12:22:35Z

I'll suggest using includes rather then a nested for loop.

You should also move the remove var outside of the loop, so it's not reinitialised every time.

The callback to the filter method is a predicate. If the condition evaluates to true, the current value in the iteration will be returned. In your case, you want to return if the current value is not in the remove array.

let data = [
  {
      id: '1',
      title: 'ABC'
  },
  {
      id: '2',
      title: 'DEF'
  },
  {
      id: '3',
      title: 'GHI'
  },
  {
      id: '4',
      title: 'JKL'
  },
  {
      id: '5',
      title: 'MNO'
  }
]

const remove = ['2', '4', '5']

data = data.filter(post => {
  return !remove.includes(post.id)
})

console.log(data)

Collectives™ on Stack Overflow

Javascript filter method, Remove all Items with matching values in array

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related