Refactoring if-else code into more maintainable code

Question

I have a code, which basically validates the input fields by parsing the JSON Into Dict(user_data()). and then checking which fields might have entered wrong and storing into errors

 errors = {}
 for key, value in user_data().items():
    if key in ["value1", "value2"]:
        if validator1(value) == False
              errors[key] = False
    elif key in ["value3", "value4"]:
        if validator2(value) == False
              errors[key] = False
    elif key in ["value5"]:
        if validator3(value) == False
              errors[key] = False
     ..........
     ..........
return errors

Is there a better way to refactor this code, and coding in this manner will it affect maintaining the code in future? Thanks

Robin Zigmond · Accepted Answer · 2019-11-28 21:54:48Z

3

You could maintain a dictionary showing which validators apply to which values:

validators = {"value1": validator1, "value2": validator1, "value3": validator2, ...}

And then replace your code with just:

errors = {}
for key, value in user_data().items():
    if validators[key](value) == False
        errors[key] = False
return errors

answered Nov 28, 2019 at 21:54

Robin Zigmond

18.3k2 gold badges25 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Rahul Reddy Over a year ago

suppose there are validators with different number of arguments!! In that case I should have multiple if statements right ?

Robin Zigmond Over a year ago

In that case the question is, what do you need to pass as the other arguments? Presumably they're fixed for a particular key - so in that case your validators dict can have a value like lambda val: validator1(val, theOtherArgument). And you can extract those into named functions if it's easier, particularly if you'll be doing a lot of this.

Rahul Reddy Over a year ago

It worked !! using lambda.Thanks I am unable to get this point And you can extract those into named functions if it's easier Thanks !!

Robin Zigmond Over a year ago

I just meant that if you don't like using lambdas (Python's syntax for anonymous functions is imo rather annoying compared to some other languages) you could define separate functions which do the same job (calling a validator with its own argument and whichever other arguments are needed).

Collectives™ on Stack Overflow

Refactoring if-else code into more maintainable code

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related