creating an array in a Rails 3 controller

Question

Some clients will have 30 questions and answers, some will have 20 and some will have 10. Those that have 10 or 20 can increase to the next level. In the controller i need to fill in for the answers that are missing. I had hoped to create one array in the controller with the question and answer matched and then send one array to the view.

@questions = Question.order("qtype, position")
@answers = Answer.where(user_id = current_user.id)

@questions.each do |q|
   @qa[q,0] = q.question
   @qa[q,1] = @answers.find_by_question_id(q.id)
   if @qa[q,1].empty?
      @qa[q,1] = 0
   end
end

I am getting "undefined method `question'." Don't know what i am doing wrong.

Thanks.

My answer addresses why you get the undefined method, but I feel like it's incomplete in the grand scheme of what you're trying to accomplish. What is @qa? — McStretch
– McStretch, Commented May 3, 2011 at 15:00
@McStretch, i was attempting to put the question (string) and the answer (integer) in a new array,... @qa. — Jay
– Jay, Commented May 3, 2011 at 15:51

McStretch · Accepted Answer · 2011-05-03 14:55:16Z

4

You are calling .question on a Ruby Array (@questions), which does not have a question method.

The block argument q is the individual question that you want to access on each iteration.

answered May 3, 2011 at 14:55

McStretch

20.7k2 gold badges38 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jay Over a year ago

oh bother... its all in the details.

Austin Taylor · Accepted Answer · 2011-05-03 15:02:32Z

1

You can do this very easily in ruby using map:

@qa = @questions.map { |q| [q, @answers.find_by_question_id(q.id)] }

Since you have already loaded a correctly filtered answer array, it's actually more performant to do this:

@qa = @questions.map { |q| [q, @answers.detect {|a| a.question == q}] }

You would do well to spend some time reading up about Array and Enumerable in ruby.

answered May 3, 2011 at 15:02

Austin Taylor

5,4771 gold badge25 silver badges30 bronze badges

4 Comments

Jay Over a year ago

thanks! Tonight i'll study array and enumerable via Google Search. Thanks for the feedback.

Jay Over a year ago

if i am getting this correctly, @qa then doesn't contain the question and the answer. It places the answer in @qa and assures that it matches the @question iteration. Correct?

Jay Over a year ago

also, if i am getting this correctly, if there is no answer for the question it doesn't the answer to 0.

Austin Taylor Over a year ago

I'm not sure what you're trying to do with 0. The answer will be nil if there isn't one, which is more idiomatic in ruby. You could do something like [q, @answers.detect {...} || 0] if you really want 0.

Collectives™ on Stack Overflow

creating an array in a Rails 3 controller

2 Answers 2

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related