How to append data properly to a JSON using python

Question

Update: The only issue I have now is when running the command to add a user it create a completely duplicate key.

Question: json.dump() simply adds the entry to the end of the json, I want it to overwrite the entire file with the new updated entry

Setup: (Create blank "Banks" Field)

        with open(DATA_FILENAME, mode='w', encoding='utf-8') as f:
            data = {"banks": []}
            json.dump(data, f)

Set User: (Create a User Key inside "Banks")

            member = ctx.message.author
            entry = {'name': member.name, 'id': member.id, 'balance': 0}

            with open(DATA_FILENAME, 'r+') as outfile:
                data = json.load(outfile)
                data['banks'].append((entry))
                json.dump(data, outfile, indent=4)

Output of first use:

{"banks": []}{
    "banks": [
        {
            "name": "ViperZ-14",
            "id": 367151547575959562,
            "balance": 0
        }
    ]
}

What I need:

{
    "banks": [
        {
            "name": "ViperZ-14",
            "id": 367151547575959562,
            "balance": 0
        }
    ]
}

Possible duplicate of How do you append to a file in Python? — Vishnudev Krishnadas
– Vishnudev Krishnadas, Commented Oct 28, 2019 at 6:38
that directly appends the text, i would like it to be formated i.e. with seperators like commas and placed inside of [] and such @Vishnudev — Jamie
– Jamie, Commented Oct 28, 2019 at 6:40
Read the file, load the json onto a variable, append data to that variable and write to the file. — Vishnudev Krishnadas
– Vishnudev Krishnadas, Commented Oct 28, 2019 at 6:42
@Vishnudev above is my attempt to what you stated, for some reason it throws an error at line 29 which is the json.load(). — Jamie
– Jamie, Commented Oct 28, 2019 at 6:47

Vishnudev Krishnadas · Accepted Answer · 2019-10-28 07:37:44Z

1

file_path = '/home/vishnudev/Downloads/new.json'
import json

def load(file, mode, data=[]):
    with open(file, mode) as f:
        if mode == 'r':
            return json.load(f)
        elif mode == 'w':
            json.dump(data, f)

def get_data_func():
    return {
        'name': 'vishnu',
        'data': 'dev'
    }

d = load(file_path, 'r')
print(d)

d.append(get_data_func())

load(file_path, 'w', d)

d = load(file_path, 'r')
print(d)

Output:

On running the above twice I get

[{'name': 'vishnu', 'data': 'dev'}]
[{'name': 'vishnu', 'data': 'dev'}, {'name': 'vishnu', 'data': 'dev'}]

answered Oct 28, 2019 at 7:37

Vishnudev Krishnadas

11k2 gold badges29 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jamie · Accepted Answer · 2019-10-28 07:28:11Z

0

I have found that the solution was to simply seek to the beginning of the document. The json.dump() does overwrite but it only overwrites whats in its way. AKA, seeking/placing the cursor at the top of the document will overwrite the entire document using the new entry.

answered Oct 28, 2019 at 7:28

Jamie

1011 silver badge12 bronze badges

1 Comment

Vishnudev Krishnadas Over a year ago

No need to seek.

Collectives™ on Stack Overflow

How to append data properly to a JSON using python

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related