Calling JavaScript from JSF component seems wrong

Question

Calling JavaScript from JSF component as follows seems to be wrong. Can you tell me why?

<ui:define name="javascript">
    <script type="text/javascript">

            function myFunction( message ){
               alert( message);
            }   

    </script>
</ui:define>

<h:commandButton id="bas" value="bas"
    onclick=" myFunction('call js Function'); " />

BalusC · Accepted Answer · 2011-04-27 20:57:15Z

1

Two things are "not right":

You need to put JS code in its own JS file and use <script src="js/foo.js"></script>. JS language namely contains operators which are illegal in XHTML based view technology such as Facelets, e.g. <, >, & and on. You would need to escape them or wrap it in a CDATA block which is plain ugly.

If you're on JSF 2.0, you should be using <h:outputScript> instead of <ui:define> with a <script>.

<h:outputScript library="js" name="foo.js" />
<h:commandButton id="bas" value="bas" onclick="myFunction('call js Function');" />

edited Apr 27, 2011 at 20:57

answered Apr 27, 2011 at 17:58

BalusC

1.1m377 gold badges3.7k silver badges3.6k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Calling JavaScript from JSF component seems wrong

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related