Laravel - Removing object inside of array based on key value - array_filter

Question

I'm having trouble removing an object inside of this array.

First I get the $id that is to be removed from the array. But when I'm filtering throw the array its appending keys to it.

So the logic ll no longer work on the rest of the application.

How can I maintain the same syntax on the options object after removing the object inside of the cart array ?

    public function destroy( $id,  Request $request )
    {
        $user = $this->user ;

        $data = array_filter( $user->options->cart , function ( $option ) use ( $id ) {
            if ( $option->product_id ==  $id ) {
                return false;
            }
            return json_encode($option);
        });

        //dd($user->options->cart);
        //dd($data);

        $user->options = (object)['cart' => $data ];
        $user->save() ;
        return response()->json( $user , 200 ) ;

    }

Solved :

    public function destroy( $id,  Request $request )
    {
        $user = $this->user ;

        $data = array_filter( $user->options->cart , function ( $option ) use ( $id ) {
            if ( $option->product_id ==  $id ) {
                return false;
            }
            return true;
        });


        $user->options = ['cart' => array_values( $data ) ];
        $user->save() ;
        return response()->json( $user , 200 ) ;

    }
}

iBrahem Kamal · Accepted Answer · 2019-07-09 13:43:36Z

4

if i understood u right , u want to rearrange the array after u do your logic plus keeping the structure , i would suggest you to use array_values

$new_data= array_values($data);

and if u got an error that its not an array although i doubt that just use the toArray() method

$new_data= array_values($data->toArray());

answered Jul 9, 2019 at 13:43

iBrahem Kamal

683 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

S. Imp · Accepted Answer · 2019-07-09 14:30:31Z

1

Looking at your JSON encoding, I see that your options object on the bottom left is an object that contains a property, cart, which is an array. Your options object on the bottom right is an object that contains a property, cart, which is an object that contains a property for each numeric index.

I'm not at all certain, but I think the problem might be that the array_filter function preserves the array keys:

If the callback function returns TRUE, the current value from array is returned into the result array. Array keys are preserved.

I suggest you try using some approach that does not try to preserve array keys so that your filtered array has contiguous, numeric values.

public function destroy( $id,  Request $request )
{
    foreach($this->user->options->cart as $key => $cart_item) {
        if ($cart_item->product_id == $id) {
            unset($this->user->options->cart[$key]);
        }
    }

    $user->save() ;
    return response()->json( $user , 200 ) ;

}

EDIT: I am not privy to the details of your implementation (I don't know what type of object $user is or what $user->save or $response->json() might do) but this code will remove an array element by product_id:

$arr = array(
        (object)["product_id" => 819, "name" => "I am 819"],
        (object)["product_id" => 820, "name" => "I am 820"],
        (object)["product_id" => 821, "name" => "I am 821"],
        (object)["product_id" => 822, "name" => "I am 822"]
);


foreach($arr as $key => $v) {
        if ($v->product_id == 820) {
                unset($arr[$key]);
        }
}

var_dump($arr);

edited Jul 9, 2019 at 14:30

answered Jul 9, 2019 at 14:01

S. Imp

2,87714 silver badges30 bronze badges

2 Comments

rocket_moon Over a year ago

This solution doesn't work. The data of $this->user->options->cart is the same. Nothing is removed. The unset function doesn't do anything in this case.

S. Imp Over a year ago

@bmpf_pt oh that's too bad. I've edited my post to clarify my thinking. I'm not aware of how your underlying code is implemented. Weird that it doesn't work.

Thomas · Accepted Answer · 2019-07-09 13:43:53Z

0

It seems like (object)['cart' => $data ] is somehow changing your array.

Setting the property directly should work:

$user->options->cart = $data;

Also, return json_encode($option); doesn't have any real effect except making the execution slower. You can just return true;.

answered Jul 9, 2019 at 13:43

Thomas

8,8592 gold badges28 silver badges54 bronze badges

1 Comment

rocket_moon Over a year ago

This its not changing anything :/ $user->options->cart = $data;

Collectives™ on Stack Overflow

Laravel - Removing object inside of array based on key value - array_filter

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related