Having difficulty understanding Python OOP

Question

I'm fairly green to OOP and I was just playing around with it in Python and came across something I can't explain so hopefully you guys will be able to help.

I was playing with the code below:

class Car():
    def __init__(self, brand, model, speed):
        self.brand = brand
        self.model = model
        self.speed = speed

    def increase_speed(self):
        return self.speed + 1


    def decrease_speed(self, decrease_by):
        return self.speed - decrease_by

car1 = Car("tesla","x",30)
print(car1.brand)
print(car1.speed)
print(car1.increase_speed())
print(car1.speed)
print(car1.decrease_speed(10))

My question is, I am expecting after increasing the speed, car1's speed will be 31 but instead it prints out 30. Why is it that way and how should the code be written for the speed to be 31 instead?

You haven't assigned the increased speed back to the origial self.speed. Thus increase_speed didn't really increased the speed; it just showed 1 unit higher speed and gone. — Chris
– Chris, Commented Mar 15, 2019 at 12:24
....and BTW that's not a problem of OOP, but just the "P" in OOP — mikuszefski
– mikuszefski, Commented Mar 15, 2019 at 12:26

Siong Thye Goh · Accepted Answer · 2019-03-15 12:25:25Z

3

def increase_speed(self):
    self.speed += 1
    return self.speed

Previously you did not increase your speed, rather you just return a value that is equal to the speed plus 1. Similarly, change your decrease_speed function.

answered Mar 15, 2019 at 12:25

Siong Thye Goh

3,58410 gold badges27 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

L3viathan · Accepted Answer · 2019-03-15 12:49:15Z

1

Instead of returning the values, set them on the attributes:

class Car():
    def __init__(self, brand, model, speed):
        self.brand = brand
        self.model = model
        self.speed = speed

    def increase_speed(self):
        self.speed = self.speed + 1


    def decrease_speed(self, decrease_by):
        self.speed = self.speed - decrease_by

I deliberately don't return the changed speed anymore, as it's good style (at least with methods mainly setting attributes) to either return something or change state:

car1 = Car("tesla","x",30)
print(car1.brand)
print(car1.speed)
car1.increase_speed()
print(car1.speed)
car1.decrease_speed(10)
print(car1.speed)

edited Mar 15, 2019 at 12:49

answered Mar 15, 2019 at 12:25

L3viathan

27.5k2 gold badges63 silver badges84 bronze badges

Comments

Samsul Islam · Accepted Answer · 2021-11-19 09:23:27Z

1

The method increase_speed is just returning self.speed + 1, if you wish to update the speed you need to self.speed = self.speed + 1 into the method increase speed.

edited Nov 19, 2021 at 9:23

Samsul Islam

2,6192 gold badges20 silver badges24 bronze badges

answered Mar 15, 2019 at 12:25

justcode

1,5973 gold badges14 silver badges25 bronze badges

Collectives™ on Stack Overflow

Having difficulty understanding Python OOP

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related