Using push for inserting JS object into an array wont work at certain context

Question

In the below code, users.push used within ‘db.each’ wont work. However, if I move ‘users.push’ outside then it seems to work.

How can I push the new objects from db.each into the users array?

let db = new sqlite3.Database('./db/main.db', (err) => {
  if (err) console.error(err.message);
  console.log('Connected to the main database.');
});

var users = [];

db.serialize(() => {
  db.each(`SELECT email, name FROM users`, (err, row) => {
    if (err) console.error(err.message);
    let user = {
      email: row.email,
      name: row.name
    }
    users.push(user);
  });
});

console.log(JSON.stringify(users));
db.close();

I am using express and sqlite3 node packages.

looks like you are pushing users inside callback, so it happens later then you try to output array to console. Does sqlite3 support promises? Code will be much more clear with async/await then — Yuri Gor
– Yuri Gor, Commented Mar 11, 2019 at 19:50
@YuriGor Thanks for the pointer. It never crossed my mind. I saw question precisely around this. stackoverflow.com/questions/46994203/… — esafwan
– esafwan, Commented Mar 11, 2019 at 20:00
Possible duplicate of How do I return the response from an asynchronous call? and Why is my variable unaltered after I modify it inside of a function? - Asynchronous code reference. — Felix Kling
– Felix Kling, Commented Mar 11, 2019 at 20:02

antoinechalifour · Accepted Answer · 2019-03-11 20:38:56Z

2

It's because db.serializeand db.each are asynchronous functions (and return immediately, thus executing console.log before the db callbacks are executed).

Here should be a working example :

db.serialize(() => {
      db.each(`SELECT email,
                      name
               FROM users`, (err, row) => {
        if (err) {
          console.error(err.message);
        }

        let user = {
            email : row.email,
            name : row.name
        }

        users.push(user);

        console.log(JSON.stringify(users));

        db.close(); 

      });
    });

edited Mar 11, 2019 at 20:38

answered Mar 11, 2019 at 19:50

antoinechalifour

4953 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nino Filiu · Accepted Answer · 2019-03-11 20:01:35Z

1

First error: asynchronicity not handled properly

As Antoine Chalifour pointed out, you call console.log(JSON.stringify(users)); before users gets modified in the asynchronous callback. Refer to his answer for fix and explanations.

Second error: errors not handled

You wrote if (err) { console.error(err.message); } then go on with the rest of the function. That is bad, because an error might happen and you'd just continue with your program. You should instead write something like:

if (err) {
  console.error(err);
  return;
}

or:

if (err) throw err;

answered Mar 11, 2019 at 20:01

Nino Filiu

18.9k11 gold badges65 silver badges97 bronze badges

Collectives™ on Stack Overflow

Using push for inserting JS object into an array wont work at certain context

2 Answers 2

Comments

First error: asynchronicity not handled properly

Second error: errors not handled

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

First error: asynchronicity not handled properly

Second error: errors not handled

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related