How do I loop through XML and print properly using elementtree in python?

Question

I am getting every childtwo in the whole xml printed with every childone in the whole document. How do I get just the childtwos that go with the childone?

import xml.etree.ElementTree as ET            
tree = ET.parse("C:/Users/thisuser/Desktop/test.xml")
root = tree.getroot()

for ticket in root.findall('.//Parent'):
    Childone = ticket.find('.//Childone').text

    for ticket in root.findall('.//ParentTwo'):
        Childtwo = ticket.find('.//Childtwo').text

        print "Childone={Childone}, Childtwo={Childtwo}".format(Childone=Childone, Childtwo=Childtwo)

Result

ChildOne=1  ChildTwo=a
ChildOne=1  ChildTwo=b
ChildOne=1  ChildTwo=c
ChildOne=1  ChildTwo=d

ChildOne=2  ChildTwo=a
ChildOne=2  ChildTwo=b
ChildOne=2  ChildTwo=c
ChildOne=2  ChildTwo=d

Desired Result

ChildOne=1  ChildTwo=a
ChildOne=1  ChildTwo=b

ChildOne=2  ChildTwo=c
ChildOne=2  ChildTwo=d

XML sample

<Parent>
    <Childone>1</Childone>
        <ParentTwo>
            <Childtwo>a</Childtwo>
        </ParentTwo>
        <ParentTwo>
            <Childtwo>b</Childtwo>
        </ParentTwo>
</Parent>

<Parent>
    <Childone>2</Childone>
        <ParentTwo>
            <Childtwo>c</Childtwo>
        </ParentTwo>
        <ParentTwo>
            <Childtwo>d</Childtwo>
        </ParentTwo>
</Parent>

Good Minimal, Complete, and Verifiable example. +1

Daniel Haley
– Daniel Haley

2019-02-26 15:29:19 +00:00
Commented Feb 26, 2019 at 15:29 — Daniel Haley
– Daniel Haley, Commented Feb 26, 2019 at 15:29
Thank you for the input.

ajd018
– ajd018

2019-02-26 18:06:22 +00:00
Commented Feb 26, 2019 at 18:06 — ajd018
– ajd018, Commented Feb 26, 2019 at 18:06

Daniel Haley · Accepted Answer · 2019-02-26 15:27:00Z

1

The issue is that you're using root in the findall of your second for loop:

for ticket in root.findall('.//ParentTwo'):

Instead, you should use ticket from the outer loop to limit what ParentTwo elements are found. (Also note I changed ticket to ticket2 since you've already used ticket.):

for ticket2 in ticket.findall('.//ParentTwo'):

Full edited code...

import xml.etree.ElementTree as ET
tree = ET.parse("C:/Users/thisuser/Desktop/test.xml")
root = tree.getroot()

for ticket in root.findall('.//Parent'):
    Childone = ticket.find('.//Childone').text

    for ticket2 in ticket.findall('.//ParentTwo'):
        Childtwo = ticket2.find('.//Childtwo').text

        print "Childone={Childone}, Childtwo={Childtwo}".format(Childone=Childone, Childtwo=Childtwo)

answered Feb 26, 2019 at 15:27

Daniel Haley

53.1k7 gold badges75 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How do I loop through XML and print properly using elementtree in python?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related