preg_replace with URL problem

Question

I use a preg_replace to auto insert HTML links within paragraphs.

Here's what I currently use:

$pattern = "~(?!(?:[^<\[]+[>\]]|[^>\]]+<\/a>))(".preg_quote($find_keyword, '/').")\b~msUi";
$replacement = "<a href=\"http://$kw_url\" title=\"$find_keyword\">\$0</a>"; 
$article_content = preg_replace($pattern, $replacement, stripslashes($article_content), 1, $added );

It works great, except 1 problem:

It doesn't match and replace if the keyword is a URL.

If: $find_keyword="http://www.mysite.com/" it won't come up with any matches even though it's in the content.

I already tried escaping $find_keyword with preg_quote, which didn't make any different.

Any regex experts know a solution? Thanks.

I already tried escaping forward slashes, which didn't make any different. — Ricky
– Ricky, Commented Mar 28, 2011 at 19:43
What happens if you pass $find_keyword through preg_quote() (as you should with all input to regex)? — John Cartwright
– John Cartwright, Commented Mar 28, 2011 at 19:45
Have you thought about users that link to http://example.com/"<script>alert("xss")</script> ? — Incognito
– Incognito, Commented Mar 28, 2011 at 19:46
No change when I try: $pattern = "~(?!(?:[^<\[]+[>\]]|[^>\]]+<\/a>))(".preg_quote($find_keyword).")\b~msUi"; — Ricky
– Ricky, Commented Mar 28, 2011 at 19:48
@user, all HTML tags are stripped from the original content. — Ricky
– Ricky, Commented Mar 28, 2011 at 19:49

vicTROLLA · Accepted Answer · 2011-03-28 20:00:36Z

1

The forward slashes in your $find_keywords are not escaped which is breaking the pattern.

answered Mar 28, 2011 at 20:00

vicTROLLA

1,52712 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ricky Over a year ago

Read the comments. They were escaped and it didn't make a difference.

Christopher Manning · Accepted Answer · 2011-03-28 20:31:58Z

0

You can run your find_keyword through

$find_keyword=preg_quote("http://www.mysite.com/", '/');

http://www.php.net/manual/en/function.preg-quote.php

answered Mar 28, 2011 at 20:31

Christopher Manning

4,5752 gold badges31 silver badges36 bronze badges

1 Comment

Christopher Manning Over a year ago

Please post sample $article_content input and your desired output.

Collectives™ on Stack Overflow

preg_replace with URL problem

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related