php mysqli if statement

Question

So I am just doing a simple email verification for testing/learning purposes, however I cannot figure out what is wrong. Here is the problem:

The query works.. it updates the field in my table, but it should only do so if it active=0. So basically, it still echo's "success" even if active=1, which it should not be able to query, because its only supposed to grab WHERE active=0 ... this make sense? Here take a look

<?php 
$connection = new mysqli('localhost', 'user', 'pass', 'db');
if (mysqli_connect_errno()) {
    printf("Can't connect to MySQL Server. Errorcode: %s\n",
        mysqli_connect_error());
    exit;
}

$email      = $_GET['email'];
$activation = $_GET['hash'];

$query = $connection->query("UPDATE users SET active = '1' WHERE
    email='".$email."' AND activationCode='".$activation."' AND active='0'");

if ($query){
    echo "success";
} else {
    echo "fail";
}

$connection->close();
?>

Oh, I guess I was under the assumption that it was true only if it found a result. How would I do that? — Chris
– Chris, Commented Mar 25, 2011 at 19:59

tvkanters · Accepted Answer · 2011-03-25 19:58:50Z

3

The query returns true because the query was executed just fine, even if it didn't affect any rows. It only returns false if the query is invalid. You should look into retrieving the number of affected rows. (mysql_num_rows($query) for example.)

Also, you should use mysql_real_escape_string($getvalue) when using values from $_GET or $_POST in your queries to prevent MySQL injection.

answered Mar 25, 2011 at 19:58

tvkanters

3,5234 gold badges32 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Chris Over a year ago

Thank you. Is there a mysqli equivalent to mysql_num_rows($query)?

tvkanters Over a year ago

Yes. Just call $connection->affected_rows after executing the query to get the amount of rows. See php.net/manual/en/mysqli.affected-rows.php for more info.

tvkanters Over a year ago

You're welcome. Please select this answer as accepted if you issue is solved now. : )

Chris Over a year ago

I gotcha bud, had to wait 58 seconds :P

tvkanters Over a year ago

Ah, alright. I didn't know that. : ) (Never actually asked a question here before. ;p)

Collectives™ on Stack Overflow

php mysqli if statement

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related