Array in while loop

Question

I created a function that read data from a mysql db.

I want to put the data into a array and read that outside of the PHP function.

function showCategory($con) {
    $sql = "SELECT * FROM kategorien";
    $kategorien = array();     

    $result = $con->query($sql);
    while($row = $result->fetch_assoc()) {
        $kategorien[] = $row["kategorie"];
        return $kategorien;
    }   
}

To load the data outside from function:

$kategorien = showCategory($con);
echo $kategorien['kategorie'][0];

It doesn't work. Whats wrong?

First try return $kategorien; outside the While loop because return naturally ends execution of the current function — Tadiwanashe
– Tadiwanashe, Commented Jan 24, 2019 at 10:07

Nigel Ren · Accepted Answer · 2019-01-24 10:14:37Z

2

The

return $kategorien;

will exit the loop and the function, so move this to the end of the function and not in the loop.

function showCategory($con) {
    $sql = "SELECT kategorie FROM kategorien";
    $kategorien = array();     

    $result = $con->query($sql);
    while($row = $result->fetch_assoc()) {
        $kategorien[] = $row["kategorie"];
    }   
    return $kategorien;
}

Rather than using *, it's also worth specifying the column names if you only need some of them.

Display the data using...

$kategorien = showCategory($con);
print_r( $kategorien );

or use a foreach()...

$kategorien = showCategory($con);
foreach ( $kategorien as $kat ) {
    echo $kat.PHP_EOL;
}

edited Jan 24, 2019 at 10:14

answered Jan 24, 2019 at 10:04

Nigel Ren

57.3k11 gold badges49 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

fcb1900 Over a year ago

Thanks! But i'm only get only the first entry ... $kategorien = showCategory($con); echo $kategorien[0];

dWinder Over a year ago

Try print_r($kategorien) instead the echo

dWinder Over a year ago

@NigelRen you can do array_column as return array_column($result, 'kategorie'); and not use the while loop (if used fetch_assoc_all)

Nigel Ren Over a year ago

I've added a few more options to display the data - but $kategorien[0] is only the first element of the array ([0])

its_tayo · Accepted Answer · 2019-01-24 10:06:55Z

0

Use this instead, because returning $kategorien will exit the loop, so it will only run once.

function showCategory($con) {
    $sql = "SELECT * FROM kategorien";
    $kategorien = array();     

        $result = $con->query($sql);
            while($row = $result->fetch_assoc()) {
               $kategorien[] = $row["kategorie"];
            }  
            return $kategorien;
}

answered Jan 24, 2019 at 10:06

its_tayo

1,3042 gold badges14 silver badges24 bronze badges

Collectives™ on Stack Overflow

Array in while loop

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related