Why JS event "onclick" work out after second click but, not first? ASP.NET MVC

Question

Can some one tell me, Why tag a make my first click without opening the table, but take the address which should go (in first moment table is hidden)

And after second click, table is opening and I'm going to it. Without tag <a href="#[email protected]"> it open by 1 click.

#team-**@team.Id** - it's normal, i did 15 tables by cycle, and make for each table id)

My code in view

<div id=team-logo-wrapper>
<ul>
    @foreach (Team team in Model.Item2)
    {
        <li>
            <div class="team-section-box">
                <p class="team-name">@team.Name</p>
                <a href="#[email protected]">
                    <img src="@Url.Content(string.Format("~/Images/NBAlogoImg/{0}", team.Path))" class="logo-images" alt="Логотип @team.Name" title="Логотип @team.Name" onclick="ShowTable(@team.Id)" />
                </a>

            </div>
        </li>
    }
</ul>

in CSS my display and visibility

.table-hidden {
  margin-top: 50px;
  display: none;
  visibility: hidden;
}

the simplest script

var flag = true;
function ShowTable(teamId) {
    var id = "team-" + teamId;
    var getElem = document.getElementById(id);

    if (flag) {
        flag = false;
        getElem.style.display = 'none';
        getElem.style.visibility = 'hidden';
    }

    else {
        flag = true;
        getElem.style.display = 'block';
        getElem.style.visibility = 'visible';
    }
}

I think the problem is flag variable which is default value is true. — aseferov
– aseferov, Commented Jan 9, 2019 at 10:23
yor are right, thank you!!!(don't know, why i did't think about flag!) — user10848771
– user10848771, Commented Jan 9, 2019 at 10:50

Robert Harvey · Accepted Answer · 2019-01-08 19:43:10Z

2

When you click on the image, you also activate the link.

If you really need the link, then change it to something like:

<a  href="javascript: void(0)">
  <img src="@Url.Content(string.Format("~/Images/NBAlogoImg/{0}", team.Path))" 
       class="logo-images" alt="Логотип @team.Name" 
       title="Логотип @team.Name" 
       onclick="ShowTable(@team.Id)" />
 </a>

edited Jan 8, 2019 at 19:43

Robert Harvey

182k48 gold badges349 silver badges516 bronze badges

answered Jan 8, 2019 at 19:27

MikNiller

1,27011 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user10848771 Over a year ago

it helpes, but I have on quastion, if i have 5 tables, open first by 1 click(good), and i want open second table too(dont close first). It openes by second click, why? (if open than close , and next table work right)

Collectives™ on Stack Overflow

Why JS event "onclick" work out after second click but, not first? ASP.NET MVC

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related