passing arguments in onclick functions appended from Javascript

Question

I have a piece of code which looks like the following,

$(document).ready(function(){
  var agr1='#19865 - testArg';
  var arg2=1856
  $('#dv_Test').append('<button onclick="testFunction('+ agr1 +','+ arg2 +')">Test</button>')
});
function testFunction(arg1, arg2) { 
  alert(arg1);
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div id="dv_Test"></div>

here I am getting error like the following

testFunction(#19865 - testArg,1856)

Uncaught SyntaxError: Invalid or unexpected token

and my string agr1 doesn't have "" with itself

how can I solve this issue?

But why are you using inline handlers? $('<button />').click(function() { // access scope variables normally}) — Yury Tarabanko
– Yury Tarabanko, Commented Jan 2, 2019 at 12:02
this is just an example I am getting data from database and binding this to table — user6656728
– user6656728, Commented Jan 2, 2019 at 12:03
your inline arguments should be strings if they are meant to be so. In a nutshell, you need to escape them, hence the "invalid or unexpected token" exception. — briosheje
– briosheje, Commented Jan 2, 2019 at 12:03
@MumbaiWadala " I am getting data from database and binding this to table" it doesn't really matter if you have access to the data (and I assume you do :)) You don't need inline handlers in year 2019. — Yury Tarabanko
– Yury Tarabanko, Commented Jan 2, 2019 at 12:05

Rory McCrossan · Accepted Answer · 2019-01-02 12:02:45Z

5

The issue is because the arg1 value is a string and needs to have quotes around it:

$(document).ready(function() {
  var agr1 = '#19865 - testArg';
  var arg2 = 1856
  $('#dv_Test').append('<button onclick="testFunction(\'' + agr1 + '\',' + arg2 + ')">Test</button>')
});

function testFunction(arg1, arg2) {
  alert(arg1);
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div id="dv_Test"></div>

However a much better way to do this would be to put those values in data attributes and add a single delegated event handler to handle all dynamically created buttons. Try this:

$(document).ready(function() {
  var agr1 = '#19865 - testArg';
  var arg2 = 1856
  var $div = $('#dv_Test').append('<button data-arg1="' + agr1 + '" data-arg2="' + arg2 + '">Test</button>');
  
  $div.on('click', 'button', function() {
    var $btn = $(this); 
    console.log($btn.data('arg1'), $btn.data('arg2'));
  }); 
});

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div id="dv_Test"></div>

answered Jan 2, 2019 at 12:02

Rory McCrossan

338k41 gold badges321 silver badges353 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user6656728 Over a year ago

thanks the second solution is really good and I will implement that.

Rory McCrossan Over a year ago

No problem, glad to help

brk · Accepted Answer · 2019-01-02 12:06:40Z

1

You need to have quotes around the argument.Alternatively you can try template literals

$(document).ready(function() {
  var agr1 = '#19865 - testArg';
  var arg2 = 1856
  $('#dv_Test').append(`<button onclick="testFunction('${agr1}','${arg2}' )">Test</button>`)
});

function testFunction(arg1, arg2) {
  alert(arg1);
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div id="dv_Test"></div>

answered Jan 2, 2019 at 12:06

brk

50.3k10 gold badges59 silver badges85 bronze badges

Collectives™ on Stack Overflow

passing arguments in onclick functions appended from Javascript

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related