Unable to fetch data from json through codable swift

Question

This is json code:

{
  "status":"success",
   "data":
     [
       {"id":"3",
        "city_name":"Delhi",
         "city_image":"delhi.png"},
       {"id":"4",
        "city_name":"Mumbai",
        "city_image":"tickmark.png"}
     ]
 }

My Swift Code :

struct city: Decodable{
    let status : String
    let id: String
    let data : String
    let city_name: String
    let city_image: String
}

class ViewController: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()

        let jsonUrl = "http://parking.onlinekiduniya.org/api/cityList.php"
        let url = URL(string: jsonUrl)
        URLSession.shared.dataTask(with: url!) {(data, response, error) in
            do {
                let cities = try JSONDecoder().decode([city].self, from: data!)
                for city in cities {
                print(city.id)
            }
            }
            catch {
                print("we got error")
        }
        }.resume()
    }
}

Shehata Gamal · Accepted Answer · 2018-12-30 12:44:09Z

1

Replace

let cities = try JSONDecoder().decode([city].self, from: data!)

with

let root = try JSONDecoder().decode(Root.self, from: data!)
let cities = root.data
cities.forEach {
   print($0.id)
}

struct Root: Codable {
    let status: String
    let data: [City]
}

struct City: Codable {
    let id, cityName, cityImage: String // you can use snake case also

    enum CodingKeys: String, CodingKey {
        case id
        case cityName = "city_name"
        case cityImage = "city_image"
    }
}

Your root is a dictionary not an array

edited Dec 30, 2018 at 12:44

answered Dec 30, 2018 at 12:27

Shehata Gamal

101k8 gold badges75 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Vidur Bahl Over a year ago

Ok thanks for your quick response. I replaces this line of code but now I am getting error . -----Variable used within its own initial value

Shehata Gamal Over a year ago

@VidurBahl follow the whole answer content

Vidur Bahl Over a year ago

Ok what should be print line for printing my data .? Thanks @sh_khan

Vidur Bahl Over a year ago

Thanks a lot bro you saved my day :) Very much appreciate your fast and accurate response. Also which is the good way to learn json Integration in swift. ? Thanks once again

Shehata Gamal Over a year ago

@VidurBahl first you should learn how to structure the json correctly with jsonlint.com then generate swift files with app.quicktype.io

|

Collectives™ on Stack Overflow

Unable to fetch data from json through codable swift

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related