Javascript: Replacing text in HTML object

Question

I've got a HTML object obj and I'm attempting to replace a string in it's inner HTML with another..

obj.innerHTML.replace('<a>theoldstring</a><span></span>','thenewstring');

However, the string isn't replacing and is printing the same before and after.. why?

Berzemus · Accepted Answer · 2011-03-16 10:41:27Z

3

Your call is just returning the new string. Look in the docs how javascript's replace function works.

obj.innerHTML = obj.innerHTML.replace('<a>theoldstring</a><span></span>','thenewstring');

answered Mar 16, 2011 at 10:41

Berzemus

3,65825 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Saul · Accepted Answer · 2011-03-16 10:40:49Z

1

String.replace() does not modify the original object. Instead it returns a new instance, hence an assigment is needed:

obj.innerHTML = obj.innerHTML.replace('<a>theoldstring</a><span></span>','thenewstring');

answered Mar 16, 2011 at 10:40

Saul

18k8 gold badges67 silver badges93 bronze badges

x2. · Accepted Answer · 2011-03-16 10:41:23Z

1

obj.innerHTML = obj.innerHTML.replace('<a>theoldstring</a><span></span>','thenewstring');

answered Mar 16, 2011 at 10:41

x2.

9,6586 gold badges43 silver badges63 bronze badges

Muhamad Bhaa Asfour · Accepted Answer · 2011-03-16 10:42:38Z

0

obj.innerHTML = 'thenewstring';

answered Mar 16, 2011 at 10:42

1,0353 gold badges22 silver badges40 bronze badges