PHP verify if every $array[$key] is not empty

Question

So, i have this code that seems to be doing the mechanical work correctly, avoiding to write on tables if one or more fields from a form are left empty, but the echos and messages aren't working as they supposed to:

SOLUTION TO THE PROBLEM: I don't believe this will be useful to anyone, but just for the record, the solution is simple:

$campos = array('nome','morada','email','telemovel','codigopostal','vat');
foreach ($campos as $key => $campo) {
    $campos[$key] = $_GET[$campo];
    if(!isset($_GET[$campo])|| empty($_GET[$campo])){
                header("Location: ../index.php?erro=".$campo);
                $verifica=FALSE;
                die();
            }else{
                $verifica=TRUE;
            }
}

This will give me some problems, not what i really wanted but solves the logical problems i was having. Thanks to you all guys.

$campos = array('nome','morada','email','telemovel','codigopostal','vat');
foreach ($campos as $key => $campo) {
    $campos[$key] = ($_GET[$campo]);
    while(list($key, $campo)= each($campos))
            if(!isset($_GET[$campo])|| $_GET[$campo]==""){
                echo("não preencheu um dos campos");
                $verifica = FALSE;
                die();
            }else{
        echo $_GET[$campo]." \r\n";}
        $verifica = TRUE;
}

if($verifica==TRUE){
some irrelevant code.
}

As i said, the code itself is working flawlessly, BUT if i only left 2 empty fields on the form, the echo $_GET[$campo] will be working even though the variable $verifica will be set as FALSE

AN HINT:

One of the fields is making the code to fail, is the second one, so, if i do this:

../phcexport.php?nome=myname&morada=&codigopostal=postcode&[email protected]&vat=123123&telemovel=00800

And ignore the second value from the array, the code will work like a charm, i can try as many combinations as i can as long as i left the second field empty, it will work properly, giving me the error "some field is empty", in this case i know it is, the "morada" is empty, and if i fill it in the code says "its ok, all filled in" BUT the "morada" should be the last to be filled so the code works. Funny... (I'm sorry about all the text to describe the problem, i'm Portuguese)

EDIT2: For the rest of the code i need to use $campos[$key], so attribute a key to the arrays is essencial.

mario · Accepted Answer · 2011-03-11 16:35:45Z

1

The problem is that you reset $verifica in the else. So regardless if you set it once to FALSE, the last foreach iteration will determine the outcome. But you can "simplify" the whole approach to:

$verify = array_search(0, array_map("strlen", $campos)) === false;

This simply checks for the string length of each array entry. If none of them is 0, then the expression will return true for $verify;

answered Mar 11, 2011 at 16:35

mario

146k20 gold badges243 silver badges293 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Souza Over a year ago

I will try your solution mario, thank you very much. Can you just tell me why the second value from the array is causing the problem? I am in the proccess of learning and it would be good if you could tell me, if i ignore this field and left it empty, the code will work: ../phcexport.php?nome=myname&morada=&codigopostal=postcode&[email protected]&vat=123123&telemovel=00800

mario Over a year ago

@Souza: I don't believe it is the second entry. After a second look you are using two iterators actually. The foreach conflicts with the while =each(). It's certainly some logic error, not a problem with the array values.

Souza Over a year ago

No, of course it's not the field or the array, but it was just a hint to get to the origin of the problem :P. I will take a look, probably some logic error as you said.

krtek · Accepted Answer · 2011-03-11 16:26:37Z

1

instead of doing $_GET[$campo]=="", you can maybe use the empty function :

empty($_GET[$campo])

This should address all problems related to different data types.

Your also maybe running in a problem because you're using a variable named $campo in two different loops, try changing the variable name in the while loop to see if it works better.

answered Mar 11, 2011 at 16:26

krtek

26.7k5 gold badges60 silver badges84 bronze badges

1 Comment

Souza Over a year ago

Thank you very much for your answer Krtek, i noticed something very weird now, the only field that is causing a malfunction is the second one, "morada", when this field is left empty, the code works as it should be, if i enter some value on it, it makes the echos work in a weird way. I will try to change the variable you mentioned, brb. Thank you very much.

Matt · Accepted Answer · 2011-03-11 16:27:05Z

1

Check the exact value of $campo that is causing the incorrect behaviour, then consult this table to make sure you are using the right kind of comparison

http://www.php.net/manual/en/types.comparisons.php#types.comparisions-loose

answered Mar 11, 2011 at 16:27

Matt

3,8503 gold badges32 silver badges33 bronze badges

1 Comment

Souza Over a year ago

the exact value of $campo that is giving me a hard time is "morada", it's making the code not work as it should.

opps · Accepted Answer · 2011-03-11 16:42:30Z

1

try following solution, empty fields can not pass the test

<?php
$campos = array('nome', 'morada', 'email', 'telemovel', 'codigopostal', 'vat');
$verifica = TRUE;
foreach ($campos as $campo) {
    if (!isset($_GET[$campo]) || empty($_GET[$campo])) {
        echo "não preencheu um dos campos" ;
        $verifica = FALSE;
        break;
    } else {
        echo $_GET[$campo] ."\r\n";
    }
}

if ($verifica == TRUE) {
//  some irrelevant code.
} else {
    die();
}

answered Mar 11, 2011 at 16:42

opps

2702 silver badges9 bronze badges

2 Comments

Souza Over a year ago

There is one problem, you are not attributing any keys to the arrays, on the code i will be using $campos[2] , $campos[3] , $campos[5] , $campos[7] to get my values.

opps Over a year ago

you did not mention any thing about this in your question, why don't you use $campos['nome'] to get your values? that's more friendly for us.

Collectives™ on Stack Overflow

PHP verify if every $array[$key] is not empty

4 Answers 4

3 Comments

1 Comment

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

1 Comment

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related