for loop doesen't iterate over string in a function but does without function - python 3

Question

my code:

def word_distribution(stringeling):
    for char in "?!.,":
        Satz = stringeling.replace(char,"")
    return Satz

print(word_distribution("Hallo du Peter? Du! und punkt. und komma,"))

output: Hallo du Peter Du! und punkt. und komma

The code does only remove the first "?" Why when i use the for loop without the function it prints me all the word without punctuation. Thanks for help ;)

Alright, we need a canonical question for people who assign to the wrong variable in a loop. I swear I've seen a dozen questions like this one recently. — Aran-Fey
– Aran-Fey, Commented Sep 22, 2018 at 10:27
I don't think it will remove the question mark, but only the final comma. Strings in python are immutable, each operation on the string will return a new string. — NiVeR
– NiVeR, Commented Sep 22, 2018 at 10:32
Works great know thanks! @Aran-Fey sorry i found similair questions in the search but they all forgett the return statement ;) — till Kadabra
– till Kadabra, Commented Sep 22, 2018 at 10:49

Gautam · Accepted Answer · 2018-09-22 10:29:20Z

1

You can try the following :

def word_distribution(stringeling):
    for char in "?!.,":
        stringeling = stringeling.replace(char,"")
    return stringeling.lower()

answered Sep 22, 2018 at 10:29

Gautam

1,93212 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

onno · Accepted Answer · 2018-09-22 10:28:13Z

1

you overwrite Satz every time in the loop with the original stringeling. Try:

def word_distribution(stringeling):
    for char in "?!.,":
        stringeling = stringeling.replace(char,"")
    return stringeling


print(word_distribution("Hallo du Peter? Du! und punkt. und komma,"))

answered Sep 22, 2018 at 10:28

onno

9895 silver badges10 bronze badges

Comments

sulabh chaturvedi · Accepted Answer · 2018-09-22 10:52:08Z

1

IMHO you don't really need a for loop. Since replace does a fixed replacement hence, I used sub from re module to do search and replace using regex. Below is the code

        import re
        def word_distribution(stringeling):
            Satz = re.sub('[?,.!]',"",stringeling,count=0,flags=0)
            return Satz

Output as follows

>>> print(word_distribution("Hallo du Peter? Du! und punkt. und komma,"))
Hallo du Peter Du und punkt und komma

Refer - Read documentation on re.sub here

answered Sep 22, 2018 at 10:52

sulabh chaturvedi

4,0543 gold badges16 silver badges26 bronze badges

Collectives™ on Stack Overflow

for loop doesen't iterate over string in a function but does without function - python 3

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related