Foreach loop seems to destroy the array in Laravel / PHP 7

Question

I have a simple CRUD item called Filters. In here each filter is assigned to a category with a foreign key. What I am trying to do is loop through each foregin key to get the category name rather than id to display to the user.

I get all filters first and performed a die/dump to check all results were there and they are.

When trying to assign the category name to the correct array item I get this error:

"Indirect modification of overloaded element of App\Filter has no effect"

So to check what's happening I have die/dumped inside the foreach loop and the exact same data has now disappeared. Even if I just put a foreach loop in with no modiifcaiton of the original array, when I pass this back to the view it has been unset.

AM I being very naive and not realising something this foreach loop does that destroys this data???

I have copied my code below and commented where the dd works and doesn't;

public function show()
{   
    $filter = [];
    $filter['filters'] = Filter::all();

    //dd($filter['filters']); --this works fine here
    foreach($filter['filters'] AS $key => $filter){
    //dd($filter['filters']); --this returns null here
        $category = Category::where('id', $filter->category)->first();
        $filter['filters'][$key]->category = $category->category;
    }

    return view('admin.crud.filters.index')->with('filter', $filter);
}

Afraz Ahmad · Accepted Answer · 2018-09-16 11:28:19Z

1

Don't re-initialize a variable or different data-type with same name

Try to change the $filter to something else in foreach loop. Because you already have an array with same name.

Do something like:

foreach($filter['filters'] AS $key => $f){...}

edited Sep 16, 2018 at 11:28

answered Sep 16, 2018 at 11:24

Afraz Ahmad

5,41633 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

James Over a year ago

Completely right I should've seen that! Thanks for the help I'll accept the answer as soon as I can (10 minutes left I think)

Collectives™ on Stack Overflow

Foreach loop seems to destroy the array in Laravel / PHP 7

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related