Ajax call, function callback, javascript

Question

I have function like that

function cryptChange(cr){
        var url = 'https://min-api.cryptocompare.com/data/dayAvg?fsym=' + cr + '&tsym=PLN';
        console.log(url);      // it's just for testing in console

};
cryptChange('LTC');
cryptChange('BTC');

As you can see this code is working fine with URL of AJAX call with JSON data, returning valid URL. Want to make something like that, but in shorter version, I have many lines of code like the ones below and I do want to get less

$.getJSON('https://min-api.cryptocompare.com/data/dayAvg?fsym=BTC&tsym=PLN', function(btc2){
    $('#tt-11').html(btc2.PLN.toFixed(2)); //its passed into html block
});
$.getJSON('https://min-api.cryptocompare.com/data/dayAvg?fsym=BCH&tsym=PLN', function(bch2){
        $('#tt-12').html(bch2.PLN.toFixed(2));
    });

And now I want to mix that cryptChange function with AJAX call to pass parameter for callback and use that in $ ('#tt-11').html (btc2 here <==.PLN.toFixed (2);

Is that clearer guys now?

I'm not sure I understand what your asking for with your last sentence. Edit: I'm also trying to pull up the api, because you shouldn't have to construct your url that way. getJSON should be able to accept an object with key value pairs and it will build the query string on the url for you. — Taplar
– Taplar, Commented Sep 14, 2018 at 21:12
api.jquery.com/jQuery.getJSON/#jQuery-getJSON-url-data-success yeah, so if you look at the api, the second optional argument you can give it is data. So you could have a constant variable some where with https://min-api.cryptocompare.com/data/dayAvg in it, use that variable for your url, and then give data as {fsym:'BTC', sym:'PLN'} or whatever, and getJSON will construct the url for you. This is a side note to whatever you as asking for at the bottom of your question. — Taplar
– Taplar, Commented Sep 14, 2018 at 21:15
It is not a good habit to delete the previous question where we already tried to figure out what you are asking and create a new question with the exact same content. — t.niese
– t.niese, Commented Sep 15, 2018 at 0:06
t.niese i know, but there was a mess, so here i just did more accurate topic, thank you for all your help ;) i appreciate that helping :) — wilk85
– wilk85, Commented Sep 15, 2018 at 17:28

Barmar · Accepted Answer · 2018-09-14 21:42:07Z

2

Define a function that takes all the varying parts as parameters.

function getCrypt(from, to, id) {
    $.getJSON('https://min-api.cryptocompare.com/data/dayAvg', {
        fsym: from,
        tsym: to
    }, function(result){
    $('#' + id).html(result[to].toFixed(2));
});

You can then do:

getCrypt('BTC', 'PLN', 'tt-11');
getCrypt('BCH', 'PLN', 'tt-12');

answered Sep 14, 2018 at 21:42

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

wilk85 Over a year ago

Thank You very much, it's working perfectly well, this is what i was looking for, but i couldn't get into it :) i just didnt know that the function params, that object i dont need to specify as parameter, but it's just data collected from call ;)

Collectives™ on Stack Overflow

Ajax call, function callback, javascript

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related