asp.net MVC custom Authorize attribute, passing parameters and method details

Question

I am trying to create a MVC Custom Authentication Attribute.

I have this method as follows:

[DealerContextRequired]
[CustomerContextRequiredAttribute("Invoice", "InvoiceNumber", invoiceNumber)]
public ActionResult InvoiceModal(string invoiceNumber)
{
    if (!Request.IsAjaxRequest())
       return RedirectToAction("InvoiceModal", "Orders", new { area = "my_account", headerNumber = invoiceNumber });

    InvoiceHeader invoice = _invoiceReader.Get(invoiceNumber, false);

    if (_dealerContext.CurrentFranchisee != null)
    {
       var order = _orderReader.GetByInvoiceNumber(invoice.InvoiceNumber).FirstOrDefault();
       if (order == null)
             return HttpNotFound();

       if (order.Franchisee == null || _dealerContext.CurrentFranchisee.Key != order.Franchisee.Key)
            return new HttpUnauthorizedResult();
    }

    return PartialView("InvoiceModal", invoice);
}

Below is the attribute I have created so far, I am struggling to pass the values form the controller attribute to the attribute, please see the attribute class below:

public class CustomerContextRequiredAttribute : System.Web.Mvc.AuthorizeAttribute
{
    public object Entity { get; set; }

    public string Key { get; set; }

    public int Value { get; set; }
    public CustomerContextRequiredAttribute(object entity, string key, int value)
    {
        this.Entity = entity;
        this.Key = key;
        this.Value = value;
    }

    public override void OnAuthorization(AuthorizationContext filterContext)
    {
        var customerContext = DependencyResolver.Current.GetService<CustomerContext>();
        var _customerReader = DependencyResolver.Current.GetService<ICustomerReader>();

        var entity = this.Entity;
        var key = this.Key;
        var value = this.Value;

        // some logic required for the attribute I am creating based on the above three values..

    }
}

This will be required on multiple actions so how do I get the required data / fields on the custom attribute?

Attribute parameters value in controller is not available in OnAuthorization method in CustomerContextRequiredAttribute class? — TanvirArjel
– TanvirArjel, Commented Sep 3, 2018 at 17:22
IMHO, I'm not sure this should be implemented as an "Authorization Filter". It seems you just want to ensure that Invoice exists, rather than checking if the request is authorized (who not what)? — EdSF
– EdSF, Commented Sep 3, 2018 at 17:45

Jacob · Accepted Answer · 2021-09-05 22:43:38Z

1

This looks like it should work. Passing the values to the constructor like this is acceptable.

You could try removing them from the constructor and doing the following:

[CustomerContextRequiredAttribute(Entity = "Invoice", Key = "InvoiceNumber", Value = invoiceNumber)]
public ActionResult InvoiceModal(string invoiceNumber)

edited Sep 5, 2021 at 22:43

answered Sep 3, 2018 at 20:46

Jacob

7386 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

asp.net MVC custom Authorize attribute, passing parameters and method details

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related