PHP: getting 1 instead of 0 using count()

Question

I'm adding a view counter to my website. In the code, I check if there's an IP with the id of the post.

for example when post id is 26, and there's no IP with id 26 in my IP table, it should return 0 but it returns 1 instead.

  $userIp = $_SERVER['REMOTE_ADDR'];
  $checkIp = $db->prepare("SELECT user_ip FROM user_ip WHERE word_id = '$idToShow'");
  $checkIp->execute();
//This happens
  if (count($checkIp) > 0) {
    echo count($checkIp);
    echo " ". $idToShow;
  }
//instead of this
  else {
    $insertIP = $db->prepare("INSERT INTO user_ip (user_ip, word_id) values('$userIp', '$idToShow')");
    $insertIP->execute();
    $updateView = $db->prepare("UPDATE words set views = views + 1 WHERE id = '$idToShow'");
    $updateView->execute();
  }

I have a list of words, $idToShow is the id of the word that should be showing. (for example 26)@RAUSHANKUMAR — GoddamnAllien
– GoddamnAllien, Commented Aug 25, 2018 at 6:47
Isn't $checkIp your PDOStatement object or similar? At least it isn't a result set... — sticky bit
– sticky bit, Commented Aug 25, 2018 at 6:47

Mohana Naga Venkat Sayempu · Accepted Answer · 2018-08-25 06:53:38Z

5

Assuming you are using PDO

Here you are using prepared statements for querying database, but you are not fetching the result that has been returned by a database

use

$result = $checkIp->setFetchMode(PDO::FETCH_ASSOC);
if(count($result) > 0){
  .............
}
else{
  ..........
}

Even simpler you can use

$checkIp->rowCount()

this returns number of rows effected by your query

answered Aug 25, 2018 at 6:53

Mohana Naga Venkat Sayempu

8767 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David Lartey · Accepted Answer · 2018-08-25 06:55:36Z

2

The execute() method runs the query returns a boolean value for if the query successful or not. You can use rowsCount() to count the rows or you can fetchAll() and then count the results.

You should use something like this

$checkIp->execute();
if ($checkIp && $checkIp->rowsCount() > 0) {
    // ...
}

OR

$checkIp->execute();
$ips = $checkIp->fetchAll();
if (count($ips) > 0) {
    // ...
}

http://php.net/manual/en/pdostatement.execute.php
http://php.net/manual/en/pdo.prepare.php

answered Aug 25, 2018 at 6:55

David Lartey

5798 silver badges17 bronze badges

Comments

RAUSHAN KUMAR · Accepted Answer · 2018-08-25 06:50:21Z

2

$checkIp->execute(); is always returns boolean value, so your condition is wrong here. check the docs here http://php.net/manual/en/pdostatement.execute.php use like this

$userIp = $_SERVER['REMOTE_ADDR'];
$checkIp = $db->prepare("SELECT user_ip FROM user_ip WHERE word_id = '$idToShow'");
$result=$checkIp->execute();
if (!$result) {
    echo count($checkIp);
    echo " ". $idToShow;
}else {
    $insertIP = $db->prepare("INSERT INTO user_ip (user_ip, word_id) values('$userIp', '$idToShow')");
    $insertIP->execute();
    $updateView = $db->prepare("UPDATE words set views = views + 1 WHERE id = '$idToShow'");
    $updateView->execute();
}

answered Aug 25, 2018 at 6:50

RAUSHAN KUMAR

6,0345 gold badges37 silver badges70 bronze badges

Comments

LahiruTM · Accepted Answer · 2018-08-25 06:47:07Z

1

Instead of this

if (count($checkIp) > 0)

Use

if(isset($checkIp->user_ip) && !empty($checkIp->user_ip))

answered Aug 25, 2018 at 6:47

LahiruTM

6484 silver badges16 bronze badges

Comments

ScaisEdge · Accepted Answer · 2018-08-25 06:47:13Z

1

As in PHP doc the execute retunr TRUE or False

$checkIp->execute();

so your

(count($checkIp)

just count the var content that in this case contai just a value

answered Aug 25, 2018 at 6:47

ScaisEdge

134k10 gold badges98 silver badges111 bronze badges

Comments

Nick · Accepted Answer · 2018-08-25 06:48:09Z

1

$checkIp is an object and will always (assuming your prepare was successful) return a non-zero count. What you want (assuming you are using mysqli) is $checkIp->num_rows. If you are using PDO, you want $checkIp->rowCount().

answered Aug 25, 2018 at 6:48

Nick

147k23 gold badges67 silver badges106 bronze badges

Collectives™ on Stack Overflow

PHP: getting 1 instead of 0 using count()

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related