trying to push each element with comma separated values also as an array element

Question

I have the below json object.

$scope.myDataList = [
  {name:"one,two"},
  {name:"three"},
  {name:"four"},
  {name:"five,eight,nine"}
]

I'm iterating the list and push the elements in the array as shown below.

$scope.myArray = new Array();
angular.forEach($scope.myDataList, function (value, key) { 
  $scope.myArray.push(value.name); 
});

I want to push each element with comma spearated values also in the array. example:
When I print $scope.myArray[0], it prints one,two.
But expected result is I want to print one for $scope.myArray[0] and two for $scope.myArray[1], three for $scope.myArray[2].

Each value with comma separation also I want to push as an array element.
I tried as below but does not work.

var array = $scope.myArray.split(',');

Demo: http://plnkr.co/edit/q36BQeqsj5GVNkP4PPhq?p=preview

George · Accepted Answer · 2018-08-24 14:02:10Z

1

You need to split the name and concatenate the result to the array instead:

angular.forEach($scope.myDataList, function (value, key) { 
  $scope.myArray = $scope.myArray.concat(value.name.split(',')); 
});

edited Aug 24, 2018 at 14:02

George

6,7592 gold badges31 silver badges36 bronze badges

answered Aug 24, 2018 at 14:00

31piy

23.9k6 gold badges51 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

FK82 · Accepted Answer · 2018-08-24 14:08:23Z

1

Your problem has nothing to do with AngularJS, so I rewrote it in plain JavaScript:

$scope = {};
    
$scope.myDataList = [{name:"one,two"},{name:"three"},{name:"four"},{name:"five,eight,nine"}]
	 
$scope.myArray = $scope.myDataList.map(({ name }) => name.split(','))
  .reduce((result, splitElement) => result.concat(splitElement), []);
	 
console.log($scope.myArray);

Note that the following line in your code

$scope.myArray.push(value.name);

pushes unsplit strings like 'five,eight,nine' into $scope.myArray. This is not what you want. Also, $scope.myArray.split(',') will fail, since Array.prototype has no split function.

One way to achieve the correct result is to map over the original array and split every element (the result is an array of string arrays). After that, you can join the inner string arrays together using Array.concat. This is what the following two lines do:

$scope.myArray = $scope.myDataList.map(({ name }) => name.split(','))
     .reduce((result, splitElement) => result.concat(splitElement), []);

answered Aug 24, 2018 at 14:08

FK82

5,0754 gold badges34 silver badges44 bronze badges

2 Comments

Scott Sauyet Over a year ago

Ours are very similar approaches. Is there a reason you did the two passes rather than result.concat(name.split(',')) ?

FK82 Over a year ago

@ScottSauyet No, this is just for illustration. I would probably write it like you myself.

Scott Sauyet · Accepted Answer · 2018-08-24 14:08:47Z

1

Here's a fairly simple means:

$scope.myArray = $scope.myDataList.reduce((a, {name}) => a.concat(name.split(',')), [])

Note that what you're trying to do is take the orginal list and create a new one. Since it's not a one-for-one mapping, it's not map. But reduce is appropriate, and carries more information than forEach.

const $scope = {
  myDataList: [
    {name:"one,two"},
    {name:"three"},
    {name:"four"},
    {name:"five,eight,nine"}
  ]
}

$scope.myArray = $scope.myDataList.reduce((a, {name}) => a.concat(name.split(',')), [])

console.log($scope)

answered Aug 24, 2018 at 14:08

Scott Sauyet

50.9k5 gold badges57 silver badges111 bronze badges

Comments

Gyan Prakash · Accepted Answer · 2018-08-24 14:06:43Z

0

while pushing the array element you can do:

$scope.myArray = $scope.myArray.concat(value.name.split(","));

Here is the code to try. http://plnkr.co/edit/nc91XI4vPJT0nEZvmMzU?p=preview

answered Aug 24, 2018 at 14:06

Gyan Prakash

6110 bronze badges

Collectives™ on Stack Overflow

trying to push each element with comma separated values also as an array element

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related