Add new object to array angular

Question

I'm trying to put a JSON object into an array after an API call.

First I made my API call and then I try to add every user into in a formatted JSON object.

connectionProvider.ts

import { UserModelProvider } from './../user-model/user-model';
import { MSAdal, AuthenticationContext, AuthenticationResult } from '@ionic-native/ms-adal';

export class MsConnectionProvider {
  userInfo : UserModelProvider;
  users: UserModelProvider[];

 constructor(...) {}

getUserInfo(){
    let header = new Headers({
      Authorization: this.accessToken;
    });
    let options = new RequestOptions({headers: header});

    this.usersSubscription = this.http.get("https://graph.microsoft.com/v1.0/groups/**ID**/members", options).map(res => res.json()['value']);
    this.usersSubscription.subscribe(res => {
      for (let user of res){
        this.addUserInfo(user.displayName, user.jobTitle, "something", user.mail);
      }
    });
  }

 addUserInfo(name, job, departement, mail){
    this.userInfo = new UserModelProvider;

    this.userInfo.name = name;
    this.userInfo.job = job;
    this.userInfo.departement = departement;
    this.userInfo.mail = mail;

    this.users.push(this.userInfo);
  }
}

userModelProvider.ts

export class UserModelProvider {
  name: string;
  job: string;
  departement: string;
  mail: string;
  photo: any;
}

The problem is when I try to push "this.userInfo = new UserModelProvider" into this.users array the function block and nothing happens.

I certainly don't understand the class, can you help me?

Thank you.

use new UserModelProvider();

Krishna Rathore
– Krishna Rathore

2018-08-23 09:18:58 +00:00
Commented Aug 23, 2018 at 9:18 — Krishna Rathore
– Krishna Rathore, Commented Aug 23, 2018 at 9:18

danday74 · Accepted Answer · 2018-08-23 09:41:03Z

4

You can't push to an array that has not been initialised.

you need to change:

users: UserModelProvider[]

to:

users: UserModelProvider[] = [];

Also (may or may not help):

Nothing is probably happening because push mutates the array and as such angular change detection may not kick in.

Instead of using push, create a new array with:

this.users = [...this.users, this.userInfo]

or in ES5:

this.users = this.users.concat([this.userInfo])

edited Aug 23, 2018 at 9:41

answered Aug 23, 2018 at 9:27

danday74

58k56 gold badges273 silver badges337 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user7430961 Over a year ago

thank you ! the problem was the declaration of users. It works perfectly with push method now.

Sajeetharan · Accepted Answer · 2018-08-23 09:18:42Z

3

Create an instance of the class before assigning the values,

this.userInfo = new UserModelProvider();

answered Aug 23, 2018 at 9:18

Sajeetharan

223k65 gold badges370 silver badges409 bronze badges

1 Comment

danday74 Over a year ago

this is correct but there are other problems with your code, see my updated answer

Collectives™ on Stack Overflow

Add new object to array angular

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related