I´m trying to convert a byte array to a delimited by comma string. I just want the values of de bytes into a string so I cand send a string to another pc via TCP.
This is the code that i´m running now and it´s working but it´s too slow (the byte array has 50000 elements). Do you have any better idea?.
Thanks.
byte[] bytes = (byte[])dt.Rows[0]["LNL_BLOB"];
string foto="";
foreach (byte b in bytes)
{
foto = foto + "," + b.ToString();
}
Use StringBuilder when doing lots of string operations. In this special case, you can also use string.Join:
string foto = string.Join(",", bytes);
Well, you're allocating 100000 strings (half from the ToString() calls, half for the intermediate strings). Have you never heard about the dangers of string concatenation, and the purpose of StringBuilder?
E.g.
byte[] bytes = (byte[])dt.Rows[0]["LNL_BLOB"];
System.Text.StringBuilder foto=new System.Text.StringBuilder();
foreach (byte b in bytes)
{
foto.AppendFormat(",{0}",b);
}
return foto.ToString(); /* Or however you're using your string now */
You could use Convert.ToBase64String rather than iterating through the bytes yourself.
byte[] data = // whatever you do to get the bytes
string sData = Convert.ToBase64String(data);
Here is the method documentation.
When you wanted to get your byte array back from the string, simply use the Convert.FromBase64String ala
byte[] imageData = Convert.FromBase64String(sData);
Use a StringBuilder it is more efficient for concat on strings.
byte[] bytes = (byte[])dt.Rows[0]["LNL_BLOB"];
StringBuilder foto = new StringBuilder();
for(int i = 0; i < bytes.Length; i++) {
foto.Append(bytes[i].ToString());
if (i != (bytes.Length - 1)) foto.Append(",");
}
You can parallelize the loop and process different areas of the array in parallel and reassemble the results. And, as others have mentioned, use StringBuilder.
