Remove object from array based on key-value combination

Question

I'm trying to remove objects from an array based on a key/value combination - in my case to remove all "non-active" users.

Example code looks like

    var items = [ 
      { "userID":"694","active": false }, 
      { "userID":"754","active": true }, 
      { "userID":"755","active": true },
      { "userID":"760","active": false },
      { "userID":"761","active": false },
      { "userID":"762","active": false }
      ]
    
        function removeByKey(array, params){
          array.some(function(item, index) {
            return (array[index][params.key] !== params.value) ? !!(array.splice(index, 1)) : false;
          });
          return array;
        }
    
     for (var i = 0; i < items.length; i++){ 
    	
    	var removed = removeByKey(items, {
          key: 'active',
          value: true
        });
    }
    
        console.log(removed);

But each time when last entry in the array contains "active": false, it will not be removed.

Any help is appreciated!

Possible duplicate of How to filter array when object key value is in array — ergonaut
– ergonaut, Commented Jul 23, 2018 at 16:09

Jayffe · Accepted Answer · 2018-07-23 16:13:13Z

1

maybe with a function like that :

function removeByKey(array, params){

  return array.filter( item => item[params.key] !== params.value)
}

answered Jul 23, 2018 at 16:13

Jayffe

1,28910 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jonas Wilms · Accepted Answer · 2018-07-23 16:21:21Z

1

Because if you remove an element (lets say the second last), then the for loop will skip the next one as its index gets smaller. If you want to stay with your custom remover function you have to call it like this:

let previous;
do {
    previous = items.length;
    removeByKey(items, {
      key: 'active',
      value: true
    });
 } while(previous !== items.length)

But thats actually quite inefficient, so you should modify the method that it removes all occurences and not just the first found (forEach instead of some, or just filter it)

answered Jul 23, 2018 at 16:21

Jonas Wilms

139k20 gold badges164 silver badges164 bronze badges

Comments

Wojtek Szafraniec · Accepted Answer · 2018-07-23 16:11:53Z

0

var filteredItems = items.filter(item => item.active);

answered Jul 23, 2018 at 16:11

Wojtek Szafraniec

6194 silver badges7 bronze badges

Comments

JackTheKnife · Accepted Answer · 2018-07-23 17:24:08Z

0

ES5 version of @Jayfee answer:

 function removeByKey(array, params){

    return array.filter(function (item) {
      return item[params.key] !== params.value;
    });
}

answered Jul 23, 2018 at 17:24

JackTheKnife

4,2349 gold badges72 silver badges138 bronze badges

Collectives™ on Stack Overflow

Remove object from array based on key-value combination

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related