Javascript: add onclick attribute DOM

Question

I've tryed to add some listeners to an existing div element

        //Prepare div
        $(this.div).css("z-index","256");
        $(this.div).attr("onmouseover",this.myname+".resize();");
        $(this.div).attr("onmousedown",this.myname+".resize();");
        $(this.div).attr("onmouseout","if("+this.myname+".sized)"+ this.myname+".resize();");

but in IE and Chrome the Event just doesn't get fired while it still gets added to the elements attributes. Firefox works as expected.

Does someone know whats wrong with it?

Thanks

You should really be using jquery's own evenhandling (.hover()) rather than adding to the attributes. — JohnP
– JohnP, Commented Feb 27, 2011 at 18:45

SLaks · Accepted Answer · 2011-02-27 18:45:16Z

4

Do not set events as strings.
Instead, you should use jQuery's bind method:

var me = this;    //Inside the handlers, this is the element.

$(this.div).bind('mouseenter mousedown mouseleave',  function() { 
    me.resize(); 
});

answered Feb 27, 2011 at 18:45

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gblazex Over a year ago

@Mereep - Also you don't have to create 4 instances of jQuery in order to do this. Use method chaining.

Collectives™ on Stack Overflow

Javascript: add onclick attribute DOM

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related