Logic Error in Java For-loop

Question

I am trying to make the loop continue to execute here until the user types the letter S at the keyboard. It seems to be giving three outputs instead of one for each iteration. What am I doing wrong here;

// Loop until an S is typed

public class ForTest {

    public static void main(String[] args) 
        throws java.io.IOException {

        int i;

        System.out.println("Type S to stop.");

        for(i = 0; (char) System.in.read() != 'S'; i++) 
//          System.out.println("print");
            System.out.println("Pass # " + i);
//          System.out.println("print");


    }

}

Output coming up is if I press 'a':

Type S to stop.
a
Pass # 0
Pass # 1
Pass # 2

Possible duplicate of stackoverflow.com/questions/12898455/… — Scary Wombat
– Scary Wombat, Commented Jul 4, 2018 at 6:55
it doesn't print that just tried but when I enter anything it prints twice means the iteration runs twice — Danyal Sandeelo
– Danyal Sandeelo, Commented Jul 4, 2018 at 6:55

Laurent B · Accepted Answer · 2018-07-04 08:04:30Z

2

The InputStream.read method block until the end of input which is on a Windows OS the control characters CR LF (\r\n).

This explains why you get 3 characters as a result.

See for yourself :

public static void main(String[] args) throws java.io.IOException {

    int i;

    System.out.println("Type S to stop.");

    char c = (char) 0;
    for (i = 0; c != 'S'; i++) {
        c = (char) System.in.read();
        System.out.println("Pass # " + i);
        System.out.println("char intValue : " + (int) c);
    }
}

Suggested read : Java: How to get input from System.console()

edited Jul 4, 2018 at 8:04

answered Jul 4, 2018 at 7:12

Laurent B

2,22020 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Othello Over a year ago

This code works. I like the way you introduced the (int)c to make me follow the trail. Now I checked CR LF on the ascii table and I see they are printed each time hence the three outputs. Thanks

user4142018 · Accepted Answer · 2018-07-04 07:50:45Z

1

System.in will use BufferedInputSteam to read the input from console bit by bit (including the line break, etc). In Mac system, I get 2 bits whenever i gave a single digit input.

Use Scanner and read all the bytes and convert as String.

answered Jul 4, 2018 at 7:50

user4142018

5601 gold badge5 silver badges12 bronze badges

Comments

Leviand · Accepted Answer · 2018-07-04 07:21:13Z

0

I suggest you to avoid reading input in that way, use Scanner instead. You can reach your goal with this code:

    int i = 0;
    Scanner scan = new Scanner(System.in);
    System.out.println("Type S to stop.");
    while( !scan.next().equals("S")) {
        i++;
        System.out.println("Pass # "+i);
    }

answered Jul 4, 2018 at 7:21

Leviand

2,8034 gold badges33 silver badges46 bronze badges

2 Comments

Boris the Spider Over a year ago

You still need to consume the linebreaks - this doesn't solve anything.

Othello Over a year ago

I tried it and it works. I had to import Scanner. Thanks

Collectives™ on Stack Overflow

Logic Error in Java For-loop

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related