Escaping HTML in Ruby & adding to DOM with JS

Question

I'm trying to dynamically add contents of a div using JS. Back end is Ruby on Rails. I am having a problem. Here's what is included in the view file:

var product_sidebar_inner = "<%= CGI.escapeHTML(render(...some partial...)).gsub(/\r/," ").gsub(/\n/," ") %>";

document.getElementById("left_sidebar_wrapper").innerHTML = unescape(product_sidebar_inner);

The above inserts html as text to div#left_sidebar_wrapper. Spent some time on this but still can't make this work. Any idea what am I am doing wrong?

mu is too short · Accepted Answer · 2011-03-01 06:47:09Z

1

Based on your comment to macarthy, I think you want CGI.escape (or CGI.unescape), that's what you use for URL encoding. You can also use URI.escape (or URI.unescape) but you'll get tired of having to pass the unsafe regex all the time to get it to do what you want.

Also, on the JavaScript side, you should be using encodeURI or encodeURIComponent as escape is deprecated because it has problems with non-ASCII characters.

edited Mar 1, 2011 at 6:47

answered Feb 24, 2011 at 3:34

mu is too short

436k71 gold badges863 silver badges822 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

macarthy · Accepted Answer · 2011-02-24 01:33:19Z

0

THink you need to use raw

unescape(raw(product_sidebar_inner));

answered Feb 24, 2011 at 1:33

macarthy

3,0692 gold badges24 silver badges24 bronze badges

1 Comment

mvbl fst Over a year ago

Well actually problem is on Ruby side. CGI.escapeHTML() escapes a test <h1> tag as '<h1>Test h1 -- escapeHTML</h1>', while JS escape() produces '%3Ch1%3ETest%20h1%20--%20escapeHTML%3C/h1%3E'. Latter is the right one as it will be unescaped by JS nicely. So I need a function in RoR that produces result equivalent to JS escape()

Collectives™ on Stack Overflow

Escaping HTML in Ruby & adding to DOM with JS

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related